You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/27 21:00:41 UTC

[GitHub] [arrow] seddonm1 commented on pull request #9015: ARROW-10712: [Rust] [DataFusion] Add tests to TPC-H benchmarks

seddonm1 commented on pull request #9015:
URL: https://github.com/apache/arrow/pull/9015#issuecomment-751515480


   @alamb thanks for your feedback.
   
   This PR was based on the work @andygrove started here https://github.com/apache/arrow/pull/8760 and was really just the work of loading the tpch-gen answers and adding the comparison code.
   
   The original intention of Andy's work was to allow us to automate the tpch-gen process in the CICD testing allowing verification of a real-world test set - and actually quite a wide coverage test. This is why running without TPCH_DATA set does not fail the test - as we probably do not want to enable the automated testing yet nor make all PRs fail testing.
   
   If this rationale makes sense I can do some work on the README to make this clear?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org