You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Eric Evans (JIRA)" <ji...@apache.org> on 2010/08/07 02:13:16 UTC
[jira] Created: (THRIFT-841) Build cruft
Build cruft
-----------
Key: THRIFT-841
URL: https://issues.apache.org/jira/browse/THRIFT-841
Project: Thrift
Issue Type: Bug
Affects Versions: 0.3
Reporter: Eric Evans
The following files are shipped in the binary release artifacts, (despite being removed in the clean target). This creates problems for packaging where it is typical to import to the binary releases into a vcs alongside the packaging artifacts.
{noformat}
compiler/cpp/thriftl.cc
compiler/cpp/thrifty.cc
compiler/cpp/thrifty.h
config.h
lib/erl/Makefile
lib/php/Makefile
test/py/Makefile
test/rb/Makefile
{noformat}
Also, the following is generated during a build, but not removed on a clean.
{noformat}
lib/perl/test/Makefile
{noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-841) Build cruft
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-841:
-------------------------------
Component/s: Build Process
> Build cruft
> -----------
>
> Key: THRIFT-841
> URL: https://issues.apache.org/jira/browse/THRIFT-841
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Affects Versions: 0.3
> Reporter: Eric Evans
>
> The following files are shipped in the binary release artifacts, (despite being removed in the clean target). This creates problems for packaging where it is typical to import to the binary releases into a vcs alongside the packaging artifacts.
> {noformat}
> compiler/cpp/thriftl.cc
> compiler/cpp/thrifty.cc
> compiler/cpp/thrifty.h
> config.h
> lib/erl/Makefile
> lib/php/Makefile
> test/py/Makefile
> test/rb/Makefile
> {noformat}
> Also, the following is generated during a build, but not removed on a clean.
> {noformat}
> lib/perl/test/Makefile
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-841) Build cruft
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917868#action_12917868 ]
David Reiss commented on THRIFT-841:
------------------------------------
Sorry, I meant to say that thriftl.cc is generated by lex and the other two are yacc.
lib/erl/Makefile and lib/php/Makefile should be fixed in trunk. I'm not sure what is the most maintainable way to handle the others.
> Build cruft
> -----------
>
> Key: THRIFT-841
> URL: https://issues.apache.org/jira/browse/THRIFT-841
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Eric Evans
>
> The following files are shipped in the binary release artifacts, (despite being removed in the clean target). This creates problems for packaging where it is typical to import to the binary releases into a vcs alongside the packaging artifacts.
> {noformat}
> compiler/cpp/thriftl.cc
> compiler/cpp/thrifty.cc
> compiler/cpp/thrifty.h
> config.h
> lib/erl/Makefile
> lib/php/Makefile
> test/py/Makefile
> test/rb/Makefile
> {noformat}
> Also, the following is generated during a build, but not removed on a clean.
> {noformat}
> lib/perl/test/Makefile
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-841) Build cruft
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896602#action_12896602 ]
David Reiss commented on THRIFT-841:
------------------------------------
compiler/cpp/thriftl.cc
compiler/cpp/thrifty.cc
compiler/cpp/thrifty.h
Are generated by yacc, and it's customary to include these in release tarballs so that users building the package don't need the tool installed. I'll take a look at what other packages do with respect to "make clean".
I'll try to take care of the other files.
> Build cruft
> -----------
>
> Key: THRIFT-841
> URL: https://issues.apache.org/jira/browse/THRIFT-841
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Eric Evans
>
> The following files are shipped in the binary release artifacts, (despite being removed in the clean target). This creates problems for packaging where it is typical to import to the binary releases into a vcs alongside the packaging artifacts.
> {noformat}
> compiler/cpp/thriftl.cc
> compiler/cpp/thrifty.cc
> compiler/cpp/thrifty.h
> config.h
> lib/erl/Makefile
> lib/php/Makefile
> test/py/Makefile
> test/rb/Makefile
> {noformat}
> Also, the following is generated during a build, but not removed on a clean.
> {noformat}
> lib/perl/test/Makefile
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.