You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "andreaschat-db (via GitHub)" <gi...@apache.org> on 2026/04/30 11:57:07 UTC
[PR] [WIP][SQL][DML] DSv2 Transaction API Improvements [spark]
andreaschat-db opened a new pull request, #55623:
URL: https://github.com/apache/spark/pull/55623
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR adds improvements to the Transaction API: https://github.com/apache/spark/pull/55278.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Claude Sonnet 4.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56676][SQL][DML] DSv2 Transaction API Streaming Improvements [spark]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on code in PR #55623:
URL: https://github.com/apache/spark/pull/55623#discussion_r3204025990
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1064,6 +1064,8 @@ class Analyzer(
table: NamedRelation,
withNewTable: NamedRelation => LogicalPlan): LogicalPlan = {
table match {
+ // Streaming write targets are constructed with isStreaming=false even inside a streaming
+ // query, because the sink is a regular batch write destination.
case u: UnresolvedRelation if !u.isStreaming =>
Review Comment:
Also, do we need to rename the method or even rollback the change where this code only applied to batch target?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56676][SQL][DML] DSv2 Transaction API Streaming Improvements [spark]
Posted by "andreaschat-db (via GitHub)" <gi...@apache.org>.
andreaschat-db commented on code in PR #55623:
URL: https://github.com/apache/spark/pull/55623#discussion_r3208335419
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1064,6 +1064,8 @@ class Analyzer(
table: NamedRelation,
withNewTable: NamedRelation => LogicalPlan): LogicalPlan = {
table match {
+ // Streaming write targets are constructed with isStreaming=false even inside a streaming
+ // query, because the sink is a regular batch write destination.
case u: UnresolvedRelation if !u.isStreaming =>
Review Comment:
Removed stale comment and reverted refactor.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1124,8 +1123,17 @@ class Analyzer(
case other => i.copy(table = other)
}
- case write: StreamingV2WriteCommand =>
- resolveWriteTarget(write, write.table, write.withNewTable)
+ case write: V2StreamingWriteCommand =>
+ write.table match {
+ case ref: V2TableReference =>
+ relationResolution.resolveReference(ref) match {
+ case r: NamedRelation => write.withNewTable(r)
+ case other => throw SparkException.internalError(
Review Comment:
All codepaths in `resolveReference` return `DataSourceV2Relation` which is a `NamedRelation`. Other call sites return `LogicalPlan`, so they do not need to explicitly validate the return type. I would keep the validation to be foolproof against future changes.
The alternative is to tighten the signature of `resolveReference` and return `NamedRelation` instead. Is there a particular reason, similar functions such as `loadRelation`/`getOrLoadRelation`/`adaptCachedRelation` return `LogicalPlan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56676][SQL][DML] DSv2 Transaction API Improvements [spark]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on code in PR #55623:
URL: https://github.com/apache/spark/pull/55623#discussion_r3190432006
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1064,6 +1064,8 @@ class Analyzer(
table: NamedRelation,
withNewTable: NamedRelation => LogicalPlan): LogicalPlan = {
table match {
+ // Streaming write targets are constructed with isStreaming=false even inside a streaming
+ // query, because the sink is a regular batch write destination.
case u: UnresolvedRelation if !u.isStreaming =>
Review Comment:
Don't you create `UnresolvedRelation` in `MicroBatchExecution` and control the flag?
Also, I am not sure it is a good idea to use `UnresolvedRelation` in the streaming template plan. It means we will re-resolve the target table on each batch and will not be able to detect that the table changed (e.g. dropped and recreated). I believe a better solution would be to use `V2TableReference` with a new write context (say `WriteTargetContext`). That way you can insert needed validation for each batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56676][SQL][DML] DSv2 Transaction API Improvements [spark]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on code in PR #55623:
URL: https://github.com/apache/spark/pull/55623#discussion_r3190468313
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalyzerExtensionPropagationSuite.scala:
##########
@@ -54,6 +54,22 @@ class AnalyzerExtensionPropagationSuite extends SparkFunSuite {
new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry))
test("withCatalogManager propagates all extension points") {
+ // Counts every declared field on Analyzer (backing fields for vals,
+ // constructor params, and fields inherited from mixed-in traits). When this assertion fails,
+ // a field was added to or removed from Analyzer. If the change is a new extension point,
+ // add it to Analyzer.withCatalogManager, add an assertion in the clone checks below,
+ // and update EXPECTED_FIELD_COUNT.
+ val EXPECTED_FIELD_COUNT = 12
Review Comment:
This seems more reliable. Thanks!
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalyzerExtensionPropagationSuite.scala:
##########
@@ -54,6 +54,22 @@ class AnalyzerExtensionPropagationSuite extends SparkFunSuite {
new SessionCatalog(new InMemoryCatalog, EmptyFunctionRegistry))
test("withCatalogManager propagates all extension points") {
+ // Counts every declared field on Analyzer (backing fields for vals,
+ // constructor params, and fields inherited from mixed-in traits). When this assertion fails,
+ // a field was added to or removed from Analyzer. If the change is a new extension point,
+ // add it to Analyzer.withCatalogManager, add an assertion in the clone checks below,
+ // and update EXPECTED_FIELD_COUNT.
+ val EXPECTED_FIELD_COUNT = 12
+ val analyzerFields = classOf[Analyzer].getDeclaredFields
+ .filterNot(f => f.isSynthetic || f.getName.contains("$"))
+ assert(analyzerFields.length == EXPECTED_FIELD_COUNT,
+ s"Analyzer has ${analyzerFields.length} declared fields " +
+ s"(${analyzerFields.map(_.getName).sorted.mkString(", ")}), " +
+ s"but expected $EXPECTED_FIELD_COUNT. " +
+ s"If a new extension point was added, register it in Analyzer.withCatalogManager, " +
+ s"add an assertion in this test, and update EXPECTED_FIELD_COUNT.")
+
+
Review Comment:
Minor: extra empty line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56676][SQL][DML] DSv2 Transaction API Improvements [spark]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on code in PR #55623:
URL: https://github.com/apache/spark/pull/55623#discussion_r3190434471
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/streaming/StreamingWrite.java:
##########
@@ -82,9 +82,10 @@ default boolean useCommitCoordinator() {
* multiple commits for the same epoch are idempotent.
* <p>
* Note: this method signals that all data for this write operation has been successfully written.
- * It is NOT a transactional commit. When this write is part of a
- * {@link org.apache.spark.sql.connector.catalog.transactions.Transaction}, the transaction is
- * committed separately via
+ * When this write is part of a
+ * {@link org.apache.spark.sql.connector.catalog.transactions.Transaction}, connector
Review Comment:
Can we do qualified import for `Transaction`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56676][SQL][DML] DSv2 Transactional Streaming Writes need to Validate Target between Microbatches [spark]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi closed pull request #55623: [SPARK-56676][SQL][DML] DSv2 Transactional Streaming Writes need to Validate Target between Microbatches
URL: https://github.com/apache/spark/pull/55623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56676][SQL][DML] DSv2 Transaction API Improvements [spark]
Posted by "andreaschat-db (via GitHub)" <gi...@apache.org>.
andreaschat-db commented on code in PR #55623:
URL: https://github.com/apache/spark/pull/55623#discussion_r3200172992
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1064,6 +1064,8 @@ class Analyzer(
table: NamedRelation,
withNewTable: NamedRelation => LogicalPlan): LogicalPlan = {
table match {
+ // Streaming write targets are constructed with isStreaming=false even inside a streaming
+ // query, because the sink is a regular batch write destination.
case u: UnresolvedRelation if !u.isStreaming =>
Review Comment:
Incorporated the suggestion discussed offline about using directly a `V2TableReference`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56676][SQL][DML] DSv2 Transaction API Streaming Improvements [spark]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on code in PR #55623:
URL: https://github.com/apache/spark/pull/55623#discussion_r3204021548
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1064,6 +1064,8 @@ class Analyzer(
table: NamedRelation,
withNewTable: NamedRelation => LogicalPlan): LogicalPlan = {
table match {
+ // Streaming write targets are constructed with isStreaming=false even inside a streaming
+ // query, because the sink is a regular batch write destination.
case u: UnresolvedRelation if !u.isStreaming =>
Review Comment:
Do we need the comment still?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56676][SQL][DML] DSv2 Transaction API Streaming Improvements [spark]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on code in PR #55623:
URL: https://github.com/apache/spark/pull/55623#discussion_r3204103581
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1124,8 +1123,17 @@ class Analyzer(
case other => i.copy(table = other)
}
- case write: StreamingV2WriteCommand =>
- resolveWriteTarget(write, write.table, write.withNewTable)
+ case write: V2StreamingWriteCommand =>
+ write.table match {
+ case ref: V2TableReference =>
+ relationResolution.resolveReference(ref) match {
+ case r: NamedRelation => write.withNewTable(r)
+ case other => throw SparkException.internalError(
Review Comment:
Is this guaranteed? What do we do in other places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org