You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/01/15 22:14:54 UTC
[GitHub] [druid] jihoonson opened a new pull request #10769: Update PR template to include the contributing doc; suggestion to not use force push
jihoonson opened a new pull request #10769:
URL: https://github.com/apache/druid/pull/10769
This PR has 2 changes:
- Promoting [the contributing doc](https://github.com/apache/druid/blob/master/CONTRIBUTING.md). This change also includes a suggestion for not using force pushes and rebase after creating a PR.
- Rearrange the key changes of the PR. It seems reasonable to appear before the self-checklist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] capistrant commented on a change in pull request #10769: Update PR template to include the contributing doc; suggestion to not use force push
Posted by GitBox <gi...@apache.org>.
capistrant commented on a change in pull request #10769:
URL: https://github.com/apache/druid/pull/10769#discussion_r558674556
##########
File path: .github/pull_request_template.md
##########
@@ -48,11 +57,4 @@ This PR has:
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
-<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
-
-<hr>
-
-##### Key changed/added classes in this PR
- * `MyFoo`
- * `OurBar`
- * `TheirBaz`
+<!-- Once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the contributing doc](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
Review comment:
do we want to consider raising this comment up to the top of the template in the hopes of more people reading it vs it being at the bottom and possibly being missed/ignored?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #10769: Update PR template to include the contributing doc; suggestion to not use force push
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #10769:
URL: https://github.com/apache/druid/pull/10769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] capistrant commented on a change in pull request #10769: Update PR template to include the contributing doc; suggestion to not use force push
Posted by GitBox <gi...@apache.org>.
capistrant commented on a change in pull request #10769:
URL: https://github.com/apache/druid/pull/10769#discussion_r580565940
##########
File path: .github/pull_request_template.md
##########
@@ -37,6 +39,15 @@ In each section, please describe design decisions made, including:
<hr>
+##### Key changed/added classes in this PR
+ * `MyFoo`
+ * `OurBar`
+ * `TheirBaz`
+
+<hr>
+
+<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
Review comment:
nit: comment references "checklist above", but with this change the checklist is now below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10769: Update PR template to include the contributing doc; suggestion to not use force push
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #10769:
URL: https://github.com/apache/druid/pull/10769#issuecomment-789360896
@capistrant thanks for the review. I will merge soon unless there is someone else wants to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #10769: Update PR template to include the contributing doc; suggestion to not use force push
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #10769:
URL: https://github.com/apache/druid/pull/10769#discussion_r586044013
##########
File path: .github/pull_request_template.md
##########
@@ -37,6 +39,15 @@ In each section, please describe design decisions made, including:
<hr>
+##### Key changed/added classes in this PR
+ * `MyFoo`
+ * `OurBar`
+ * `TheirBaz`
+
+<hr>
+
+<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
Review comment:
Thanks, fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #10769: Update PR template to include the contributing doc; suggestion to not use force push
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #10769:
URL: https://github.com/apache/druid/pull/10769#discussion_r558736917
##########
File path: .github/pull_request_template.md
##########
@@ -48,11 +57,4 @@ This PR has:
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
-<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
-
-<hr>
-
-##### Key changed/added classes in this PR
- * `MyFoo`
- * `OurBar`
- * `TheirBaz`
+<!-- Once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the contributing doc](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
Review comment:
Sounds good. I moved it to the top.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org