You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/25 09:14:56 UTC

[GitHub] [flink] Myasuka commented on a diff in pull request #19448: [FLINK-25872][state] Support restore from non-changelog checkpoint with changelog enabled in CLAIM mode

Myasuka commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r857419632


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionGraphFactory.java:
##########
@@ -203,10 +204,15 @@ private void tryRestoreExecutionGraphFromSavepoint(
             final CheckpointCoordinator checkpointCoordinator =
                     executionGraphToRestore.getCheckpointCoordinator();
             if (checkpointCoordinator != null) {
+                Optional<String> stateBackendName = executionGraphToRestore.getStateBackendName();
+                boolean changelogEnabled =
+                        stateBackendName.isPresent()
+                                && "ChangelogStateBackend".equals(stateBackendName.get());

Review Comment:
   @rkhachatryan , `StateBackendLoader` is called both on JM and TM side. I think we don't need to worry about this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org