You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2022/02/08 23:39:22 UTC

[GitHub] [incubator-teaclave] mssun opened a new pull request #618: Polish authentication error

mssun opened a new pull request #618:
URL: https://github.com/apache/incubator-teaclave/pull/618


   ## Description
   
   The current error handling is a bit confused. I suggest to use the following implementation conventions. Let's use the authentication service as an example:
   
   - `AuthenticationServiceError`: errors that will be propagated to the end users
   
   ## Type of change (select or add applied and delete the others)
   
   Error handling refactoring.
   
   ## How has this been tested?
   
   ## Checklist
   
   - [x] Fork the repo and create your branch from `master`.
   - [x] If you've added code that should be tested, add tests.
   - [x] If you've changed APIs, update the documentation.
   - [x] Ensure the tests pass (see CI results).
   - [x] Make sure your code lints/format.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave] mssun merged pull request #618: Polish authentication error

Posted by GitBox <gi...@apache.org>.
mssun merged pull request #618:
URL: https://github.com/apache/incubator-teaclave/pull/618


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org