Re: [PR] chore: Publish docs to arrow.apache.org [arrow-erlang]

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #68:
URL: https://github.com/apache/arrow-erlang/pull/68#discussion_r3502630233


##########
.github/workflows/docs.yml:
##########
@@ -80,11 +69,75 @@ jobs:
       - name: Generate docs
         run: rebar3 ex_doc
 
+      - name: Copy .asf.yaml
+        run: cp .asf.yaml doc
+
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v5
         with:
+          name: docs-${{ github.sha }}
           path: 'doc'
 
-      - name: Deploy to GitHub Pages
-        id: deployment
+  gh_pages:
+    # Only deploy on a push to main or on workflow dispatch
+    if: (github.ref_name == 'main' && github.event_name == 'push') || github.event_name == 'workflow_dispatch'
+    name: Deploy to GitHub Pages
+    needs: build
+
+    # Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
+    permissions:
+      contents: read
+      pages: write
+      id-token: write
+
+    environment:
+      name: github-pages
+      url: ${{ steps.deployment.outputs.page_url }}
+
+    # Allow only one concurrent deployment
+    concurrency:
+      group: "pages"
+      cancel-in-progress: true
+
+    runs-on: ubuntu-latest
+    steps:
+      - id: deployment
         uses: actions/deploy-pages@v5
+        with:
+           artifact_name: docs-${{ github.sha }}
+
+
+  asf_site:
+    # Only deploy on a push to main
+    if: github.ref_name == 'main' && github.event_name == 'push' && github.repository == 'apache/arrow-erlang'
+    name: Deploy to arrow.apache.org
+    needs: build
+
+    permissions:
+      contents: write
+
+    # Allow only one concurrent deployment
+    concurrency:
+      group: "asf_site"
+      cancel-in-progress: true
+
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - name: Download artifact
+        uses: actions/download-artifact@v8
+        with:
+          name: docs-${{ github.sha }}
+          path: docs
+      - name: Prepare website
+        run: |
+          tar -xf docs/artifact.tar -C asf-site
+          rm asf-site/artifact.tar

Review Comment:
   I just wanted to say that we don't need `rm asf-site/artifact.tar` because it doesn't exist. (It exists under `docs/`.)
   
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org