You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "LilMosey (via GitHub)" <gi...@apache.org> on 2024/12/18 04:34:57 UTC
[PR] 优化事务消息回查判断RMQ_SYS_TRANS_HALF_TOPIC是否在RMQ_SYS_TRANS_OP_HALF_TOPIC中。 [rocketmq]
LilMosey opened a new pull request, #9062:
URL: https://github.com/apache/rocketmq/pull/9062
Transaction message, check back to determine if the OP-HALF-QUEUE message is in HALF-QUEUE, optimize the judgment method
### Which Issue(s) This PR Fixes
### Brief Description
事务消息， 回查判断RMQ_SYS_TRANS_HALF_TOPIC消息是否在RMQ_SYS_TRANS_OP_HALF_TOPIC 中，优化判断方式。之前代码是先判断Map.containsKey，然后进行removeKey，新的方式是直接removeKey ！= null。
Transaction message, check back to determine if the RMQ_SYS_TRANS-HALF_TOPIC message is in RMQ_SYS_TRANS-OP_ALF_TOPIC, and optimize the judgment method. The previous code was to first determine Map.containersKey and then perform removeKey. The new approach is to directly remove the key= null。
### How Did You Test This Change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9064]Optimize the way to determine whether RMQ_SYS_TRANS-HALFTOPIC is in RMQ_SSYS_TRANS-OP_ALF_TOPIC in transaction messages [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9062:
URL: https://github.com/apache/rocketmq/pull/9062#issuecomment-2552735476
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9062?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
> Project coverage is 47.85%. Comparing base [(`93e2689`)](https://app.codecov.io/gh/apache/rocketmq/commit/93e268909cb92dd6d4033a4a36e1daab40025a75?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f13c93e`)](https://app.codecov.io/gh/apache/rocketmq/commit/f13c93e8dae7605c056d4dbaac3d0d605dfe0199?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on develop.
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/9062?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...saction/queue/TransactionalMessageServiceImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/9062?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Ftransaction%2Fqueue%2FTransactionalMessageServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdHJhbnNhY3Rpb24vcXVldWUvVHJhbnNhY3Rpb25hbE1lc3NhZ2VTZXJ2aWNlSW1wbC5qYXZh) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/9062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #9062 +/- ##
=============================================
- Coverage 47.97% 47.85% -0.13%
+ Complexity 11904 11869 -35
=============================================
Files 1312 1312
Lines 91735 91733 -2
Branches 11751 11751
=============================================
- Hits 44014 43898 -116
- Misses 42312 42414 +102
- Partials 5409 5421 +12
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9062?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9064] Optimize transaction message callback check logic [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #9062:
URL: https://github.com/apache/rocketmq/pull/9062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org