You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "LadyForest (via GitHub)" <gi...@apache.org> on 2023/03/29 14:11:49 UTC

[GitHub] [flink] LadyForest opened a new pull request, #22300: [FLINK-31165][table-planner] Improve the error message for order by clause

LadyForest opened a new pull request, #22300:
URL: https://github.com/apache/flink/pull/22300

   ## What is the purpose of the change
   
   This PR tries to improve the error message since `row_number()` without an order (or order by constants) does not make a lot of sense, and users are confused about it.
   
   
   ## Brief change log
   
   Improve the error message in `FlinkLogicalOverAggreate`
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - `RankTest` to cover both streaming and batch scenarios.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lincoln-lil commented on pull request #22300: [FLINK-31165][table-planner] Improve the error message for order by clause

Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #22300:
URL: https://github.com/apache/flink/pull/22300#issuecomment-1489577548

   @LadyForest could you also backport this to 1.17 branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] LadyForest commented on pull request #22300: [FLINK-31165][table-planner] Improve the error message for order by clause

Posted by "LadyForest (via GitHub)" <gi...@apache.org>.
LadyForest commented on PR #22300:
URL: https://github.com/apache/flink/pull/22300#issuecomment-1501523853

   > @LadyForest could you also backport this to 1.17 branch?
   
   Sure. I'll do it right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lincoln-lil merged pull request #22300: [FLINK-31165][table-planner] Improve the error message for order by clause

Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil merged PR #22300:
URL: https://github.com/apache/flink/pull/22300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22300: [FLINK-31165][table-planner] Improve the error message for order by clause

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22300:
URL: https://github.com/apache/flink/pull/22300#issuecomment-1488718703

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bd6ca5e080725498d66c436b9cf5ac2d4f38dff9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bd6ca5e080725498d66c436b9cf5ac2d4f38dff9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bd6ca5e080725498d66c436b9cf5ac2d4f38dff9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org