You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2018/08/05 17:40:10 UTC
httpcomponents-client git commit: Add missing @Override annotations.
Repository: httpcomponents-client
Updated Branches:
refs/heads/master c3bdc8913 -> 769e9fab3
Add missing @Override annotations.
Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/commit/769e9fab
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/tree/769e9fab
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/diff/769e9fab
Branch: refs/heads/master
Commit: 769e9fab3f83753661dc52e612bc1df29520be45
Parents: c3bdc89
Author: Gary Gregory <gg...@apache.org>
Authored: Sun Aug 5 11:40:07 2018 -0600
Committer: Gary Gregory <gg...@apache.org>
Committed: Sun Aug 5 11:40:07 2018 -0600
----------------------------------------------------------------------
.../hc/client5/http/cache/HttpAsyncCacheStorageAdaptor.java | 5 +++++
.../org/apache/hc/client5/testing/BasicTestAuthenticator.java | 1 +
.../hc/client5/testing/async/TestHttp1AsyncRedirects.java | 1 +
.../hc/client5/testing/sync/TestClientAuthentication.java | 1 +
.../java/org/apache/hc/client5/http/impl/RequestCopier.java | 1 +
.../hc/client5/http/impl/classic/ClassicRequestCopier.java | 1 +
6 files changed, 10 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/769e9fab/httpclient5-cache/src/main/java/org/apache/hc/client5/http/cache/HttpAsyncCacheStorageAdaptor.java
----------------------------------------------------------------------
diff --git a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/cache/HttpAsyncCacheStorageAdaptor.java b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/cache/HttpAsyncCacheStorageAdaptor.java
index 55bd095..baa8497 100644
--- a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/cache/HttpAsyncCacheStorageAdaptor.java
+++ b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/cache/HttpAsyncCacheStorageAdaptor.java
@@ -48,6 +48,7 @@ public final class HttpAsyncCacheStorageAdaptor implements HttpAsyncCacheStorage
this.cacheStorage = Args.notNull(cacheStorage, "Cache strorage");
}
+ @Override
public Cancellable putEntry(final String key, final HttpCacheEntry entry, final FutureCallback<Boolean> callback) {
Args.notEmpty(key, "Key");
Args.notNull(entry, "Cache ehtry");
@@ -61,6 +62,7 @@ public final class HttpAsyncCacheStorageAdaptor implements HttpAsyncCacheStorage
return Operations.nonCancellable();
}
+ @Override
public Cancellable getEntry(final String key, final FutureCallback<HttpCacheEntry> callback) {
Args.notEmpty(key, "Key");
Args.notNull(callback, "Callback");
@@ -73,6 +75,7 @@ public final class HttpAsyncCacheStorageAdaptor implements HttpAsyncCacheStorage
return Operations.nonCancellable();
}
+ @Override
public Cancellable removeEntry(final String key, final FutureCallback<Boolean> callback) {
Args.notEmpty(key, "Key");
Args.notNull(callback, "Callback");
@@ -85,6 +88,7 @@ public final class HttpAsyncCacheStorageAdaptor implements HttpAsyncCacheStorage
return Operations.nonCancellable();
}
+ @Override
public Cancellable updateEntry(
final String key, final HttpCacheCASOperation casOperation, final FutureCallback<Boolean> callback) {
Args.notEmpty(key, "Key");
@@ -99,6 +103,7 @@ public final class HttpAsyncCacheStorageAdaptor implements HttpAsyncCacheStorage
return Operations.nonCancellable();
}
+ @Override
public Cancellable getEntries(final Collection<String> keys, final FutureCallback<Map<String, HttpCacheEntry>> callback) {
Args.notNull(keys, "Key");
Args.notNull(callback, "Callback");
http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/769e9fab/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/BasicTestAuthenticator.java
----------------------------------------------------------------------
diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/BasicTestAuthenticator.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/BasicTestAuthenticator.java
index 933071e..aeac33f 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/BasicTestAuthenticator.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/BasicTestAuthenticator.java
@@ -42,6 +42,7 @@ public class BasicTestAuthenticator implements Authenticator {
this.realm = realm;
}
+ @Override
public boolean authenticate(final URIAuthority authority, final String requestUri, final String credentials) {
return Objects.equals(userToken, credentials);
}
http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/769e9fab/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java
----------------------------------------------------------------------
diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java
index ec97c70..8212b20 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestHttp1AsyncRedirects.java
@@ -169,6 +169,7 @@ public class TestHttp1AsyncRedirects extends AbstractHttpAsyncRedirectsTest<Clos
}
+ @Override
@Test
public void testBasicRedirect300() throws Exception {
server.register("*", new Supplier<AsyncServerExchangeHandler>() {
http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/769e9fab/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestClientAuthentication.java
----------------------------------------------------------------------
diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestClientAuthentication.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestClientAuthentication.java
index 398cea2..0e35298 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestClientAuthentication.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestClientAuthentication.java
@@ -100,6 +100,7 @@ public class TestClientAuthentication extends LocalServerTestBase {
});
}
+ @Override
public HttpHost start() throws IOException {
return start(new BasicTestAuthenticator("test:test", "test realm"));
}
http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/769e9fab/httpclient5/src/main/java/org/apache/hc/client5/http/impl/RequestCopier.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/RequestCopier.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/RequestCopier.java
index b119018..9572d5c 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/RequestCopier.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/RequestCopier.java
@@ -36,6 +36,7 @@ public final class RequestCopier implements MessageCopier<HttpRequest> {
public static final RequestCopier INSTANCE = new RequestCopier();
+ @Override
public HttpRequest copy(final HttpRequest original) {
if (original == null) {
return null;
http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/769e9fab/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ClassicRequestCopier.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ClassicRequestCopier.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ClassicRequestCopier.java
index 12f044d..ab2f7ba 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ClassicRequestCopier.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ClassicRequestCopier.java
@@ -37,6 +37,7 @@ public final class ClassicRequestCopier implements MessageCopier<ClassicHttpRequ
public static final ClassicRequestCopier INSTANCE = new ClassicRequestCopier();
+ @Override
public ClassicHttpRequest copy(final ClassicHttpRequest original) {
if (original == null) {
return null;