[GitHub] fvogler commented on issue #978: [NETBEANS-1481] Fix handling of eager module fragments (regression netbeans 9.0)

[GitBox <gi...@apache.org>]

fvogler commented on issue #978: [NETBEANS-1481] Fix handling of eager module fragments (regression netbeans 9.0)
URL: https://github.com/apache/incubator-netbeans/pull/978#issuecomment-432016967
 
 
   I closed the previous PR because there were two isolated aspects included. The eager logic is covered by this PR. The other aspect is about the contract of autoload in the context of fragmented hosts:
   * Should a fragment (not eager/autoload) trigger the enabling of the host ( in case host is autoload) because host must be loaded before fragment and fragment is a "default" module which means the module system should load it? -> To avoid this fragment must be autoload or eager.
   * Should a fragment (autoload) be loaded by the module system if host is loaded in case no one depends on it? -> Contract of autoload is broken (or different for fragments)
   
   For me it is not clear at the moment what is right. The only thing I can say  is that tests I have written against 9 are broken with 10. May be the scope of these tests is to small and overall every thing is fine. So I excluded this aspect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists