[jira] [Comment Edited] (HBASE-14575) Reduce scope of compactions holding region lock

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983963#comment-14983963 ] 

Ted Yu edited comment on HBASE-14575 at 10/31/15 11:51 AM:
-----------------------------------------------------------

bq. this patch should remove the read lock in the HRegion.compact()

This is what the patch is doing:
{code}
1787	    // block waiting for the lock for compaction		
1788	    lock.readLock().lock();
{code}
The above snippet was copied from browser which has plugin for patch files.
In the real patch, you can see '-' sign at the beginning of each line.


was (Author: yuzhihong@gmail.com):
bq. this patch should remove the read lock in the HRegion.compact()

This is what the patch is doing:
{code}
1787	    // block waiting for the lock for compaction		
1788	    lock.readLock().lock();
{code}

> Reduce scope of compactions holding region lock
> -----------------------------------------------
>
>                 Key: HBASE-14575
>                 URL: https://issues.apache.org/jira/browse/HBASE-14575
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 14575-v1.patch, 14575-v2.patch, 14575-v3.patch, 14575-v4.patch, 14575.v00.patch
>
>
> Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical section under which compactions hold the region read lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)