[GitHub] [tvm] tqchen commented on a change in pull request #8017: [IR] Add storage scope to PointerType

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #8017:
URL: https://github.com/apache/tvm/pull/8017#discussion_r630374276



##########
File path: include/tvm/ir/type.h
##########
@@ -175,8 +182,9 @@ class PointerType : public Type {
   /*!
    * \brief Constructor
    * \param element_type The type of the element which the pointer points to.
+   * \param storage_scope The storage scope into which the pointer addresses
    */
-  TVM_DLL explicit PointerType(Type element_type);
+  TVM_DLL explicit PointerType(Type element_type, String storage_scope = "global");

Review comment:
       To be consistent with the rest of the code base, let us still allow empty string, which indicates that it is global scope. We do not need to print out the scope of global ptr to simplify the readability of the Ptr type. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org