You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/05/24 19:19:50 UTC

Review Request 21888: Usability: check that hostnames are resolveable on each host

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21888/
-----------------------------------------------------------

Review request for Ambari, Mahadev Konar and Nate Cole.


Bugs: AMBARI-5885
    https://issues.apache.org/jira/browse/AMBARI-5885


Repository: ambari


Description
-------

Hooked into the custom command framework to allow for a new command, "host_resolution_check" to be executed. This will check the for-lookup for each host specified to ensure that it resolves to an IP address. It will not test reachability or that all hosts have the same addresses for each of their peers.

The command is returned in the structured_output of the task that is part of the request for the custom command.

POST request
{
  "RequestInfo": {
    "action": "check_host", 
    "context": "Check host", 
    "parameters": {
      "check_execute_list": "host_resolution_check", 
      "hosts": "c6401.ambari.apache.org, c6402.ambari.apache.org, c6403.ambari.apache.org, foobar, !!!", 
      "threshold": "20"
    }
  }, 
  "Requests/resource_filters": [
    {
      "hosts": "c6401.ambari.apache.org,c6402.ambari.apache.org"
    }
  ]

Response as part of the structured_output
{ 
'host_resolution_check': 
  {
  'failures': [
    {'type': 'FORWARD_LOOKUP', 'host': 'foobar', 'cause': [-3, 'Temporary failure in name resolution']}, 
    {'type': 'FORWARD_LOOKUP', 'host': '!!!', 'cause': [-3, 'Temporary failure in name resolution']} ],  
  'failed_count': 2, 
  'success_count': 3, 
  'exit_code': '0'
  'message': 'There were 2 host(s) that could not resolve to an IP address.', 
  }
}


Diffs
-----

  ambari-server/src/main/resources/custom_actions/check_host.py e5aa920 
  ambari-server/src/test/python/TestCheckHost.py PRE-CREATION 
  ambari-server/src/test/python/unitTests.py afd68c0 
  ambari-server/src/test/resources/custom_actions/check_host_ip_addresses.json PRE-CREATION 

Diff: https://reviews.apache.org/r/21888/diff/


Testing
-------

New python tests added.

Tests run: 1626, Failures: 0, Errors: 0, Skipped: 14

----------------------------------------------------------------------
Total run:557
Total errors:0
Total failures:0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:05.978s
[INFO] Finished at: Sat May 24 13:19:18 EDT 2014
[INFO] Final Memory: 20M/123M


Thanks,

Jonathan Hurley

Re: Review Request 21888: Usability: check that hostnames are resolveable on each host

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21888/#review43903
-----------------------------------------------------------

Ship it!



ambari-server/src/main/resources/custom_actions/check_host.py
<https://reviews.apache.org/r/21888/#comment78194>

    Should be able to do actual logging (info vs debug).  Not critical given the timeframe.



ambari-server/src/main/resources/custom_actions/check_host.py
<https://reviews.apache.org/r/21888/#comment78195>

    Can use structured logging?


- Nate Cole


On May 24, 2014, 1:19 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21888/
> -----------------------------------------------------------
> 
> (Updated May 24, 2014, 1:19 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Nate Cole.
> 
> 
> Bugs: AMBARI-5885
>     https://issues.apache.org/jira/browse/AMBARI-5885
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Hooked into the custom command framework to allow for a new command, "host_resolution_check" to be executed. This will check the for-lookup for each host specified to ensure that it resolves to an IP address. It will not test reachability or that all hosts have the same addresses for each of their peers.
> 
> The command is returned in the structured_output of the task that is part of the request for the custom command.
> 
> POST request
> {
>   "RequestInfo": {
>     "action": "check_host", 
>     "context": "Check host", 
>     "parameters": {
>       "check_execute_list": "host_resolution_check", 
>       "hosts": "c6401.ambari.apache.org, c6402.ambari.apache.org, c6403.ambari.apache.org, foobar, !!!", 
>       "threshold": "20"
>     }
>   }, 
>   "Requests/resource_filters": [
>     {
>       "hosts": "c6401.ambari.apache.org,c6402.ambari.apache.org"
>     }
>   ]
> 
> Response as part of the structured_output
> { 
> 'host_resolution_check': 
>   {
>   'failures': [
>     {'type': 'FORWARD_LOOKUP', 'host': 'foobar', 'cause': [-3, 'Temporary failure in name resolution']}, 
>     {'type': 'FORWARD_LOOKUP', 'host': '!!!', 'cause': [-3, 'Temporary failure in name resolution']} ],  
>   'failed_count': 2, 
>   'success_count': 3, 
>   'exit_code': '0'
>   'message': 'There were 2 host(s) that could not resolve to an IP address.', 
>   }
> }
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/check_host.py e5aa920 
>   ambari-server/src/test/python/TestCheckHost.py PRE-CREATION 
>   ambari-server/src/test/python/unitTests.py afd68c0 
>   ambari-server/src/test/resources/custom_actions/check_host_ip_addresses.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21888/diff/
> 
> 
> Testing
> -------
> 
> New python tests added.
> 
> Tests run: 1626, Failures: 0, Errors: 0, Skipped: 14
> 
> ----------------------------------------------------------------------
> Total run:557
> Total errors:0
> Total failures:0
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:05.978s
> [INFO] Finished at: Sat May 24 13:19:18 EDT 2014
> [INFO] Final Memory: 20M/123M
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 21888: Usability: check that hostnames are resolveable on each host

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21888/#review43900
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On May 24, 2014, 5:19 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21888/
> -----------------------------------------------------------
> 
> (Updated May 24, 2014, 5:19 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Nate Cole.
> 
> 
> Bugs: AMBARI-5885
>     https://issues.apache.org/jira/browse/AMBARI-5885
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Hooked into the custom command framework to allow for a new command, "host_resolution_check" to be executed. This will check the for-lookup for each host specified to ensure that it resolves to an IP address. It will not test reachability or that all hosts have the same addresses for each of their peers.
> 
> The command is returned in the structured_output of the task that is part of the request for the custom command.
> 
> POST request
> {
>   "RequestInfo": {
>     "action": "check_host", 
>     "context": "Check host", 
>     "parameters": {
>       "check_execute_list": "host_resolution_check", 
>       "hosts": "c6401.ambari.apache.org, c6402.ambari.apache.org, c6403.ambari.apache.org, foobar, !!!", 
>       "threshold": "20"
>     }
>   }, 
>   "Requests/resource_filters": [
>     {
>       "hosts": "c6401.ambari.apache.org,c6402.ambari.apache.org"
>     }
>   ]
> 
> Response as part of the structured_output
> { 
> 'host_resolution_check': 
>   {
>   'failures': [
>     {'type': 'FORWARD_LOOKUP', 'host': 'foobar', 'cause': [-3, 'Temporary failure in name resolution']}, 
>     {'type': 'FORWARD_LOOKUP', 'host': '!!!', 'cause': [-3, 'Temporary failure in name resolution']} ],  
>   'failed_count': 2, 
>   'success_count': 3, 
>   'exit_code': '0'
>   'message': 'There were 2 host(s) that could not resolve to an IP address.', 
>   }
> }
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/check_host.py e5aa920 
>   ambari-server/src/test/python/TestCheckHost.py PRE-CREATION 
>   ambari-server/src/test/python/unitTests.py afd68c0 
>   ambari-server/src/test/resources/custom_actions/check_host_ip_addresses.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21888/diff/
> 
> 
> Testing
> -------
> 
> New python tests added.
> 
> Tests run: 1626, Failures: 0, Errors: 0, Skipped: 14
> 
> ----------------------------------------------------------------------
> Total run:557
> Total errors:0
> Total failures:0
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:05.978s
> [INFO] Finished at: Sat May 24 13:19:18 EDT 2014
> [INFO] Final Memory: 20M/123M
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 21888: Usability: check that hostnames are resolveable on each host

Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21888/#review43908
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On May 24, 2014, 5:19 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21888/
> -----------------------------------------------------------
> 
> (Updated May 24, 2014, 5:19 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Nate Cole.
> 
> 
> Bugs: AMBARI-5885
>     https://issues.apache.org/jira/browse/AMBARI-5885
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Hooked into the custom command framework to allow for a new command, "host_resolution_check" to be executed. This will check the for-lookup for each host specified to ensure that it resolves to an IP address. It will not test reachability or that all hosts have the same addresses for each of their peers.
> 
> The command is returned in the structured_output of the task that is part of the request for the custom command.
> 
> POST request
> {
>   "RequestInfo": {
>     "action": "check_host", 
>     "context": "Check host", 
>     "parameters": {
>       "check_execute_list": "host_resolution_check", 
>       "hosts": "c6401.ambari.apache.org, c6402.ambari.apache.org, c6403.ambari.apache.org, foobar, !!!", 
>       "threshold": "20"
>     }
>   }, 
>   "Requests/resource_filters": [
>     {
>       "hosts": "c6401.ambari.apache.org,c6402.ambari.apache.org"
>     }
>   ]
> 
> Response as part of the structured_output
> { 
> 'host_resolution_check': 
>   {
>   'failures': [
>     {'type': 'FORWARD_LOOKUP', 'host': 'foobar', 'cause': [-3, 'Temporary failure in name resolution']}, 
>     {'type': 'FORWARD_LOOKUP', 'host': '!!!', 'cause': [-3, 'Temporary failure in name resolution']} ],  
>   'failed_count': 2, 
>   'success_count': 3, 
>   'exit_code': '0'
>   'message': 'There were 2 host(s) that could not resolve to an IP address.', 
>   }
> }
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/check_host.py e5aa920 
>   ambari-server/src/test/python/TestCheckHost.py PRE-CREATION 
>   ambari-server/src/test/python/unitTests.py afd68c0 
>   ambari-server/src/test/resources/custom_actions/check_host_ip_addresses.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21888/diff/
> 
> 
> Testing
> -------
> 
> New python tests added.
> 
> Tests run: 1626, Failures: 0, Errors: 0, Skipped: 14
> 
> ----------------------------------------------------------------------
> Total run:557
> Total errors:0
> Total failures:0
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:05.978s
> [INFO] Finished at: Sat May 24 13:19:18 EDT 2014
> [INFO] Final Memory: 20M/123M
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>