You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/07 21:27:20 UTC
[GitHub] [kafka] hachikuji opened a new pull request, #12390: KAFKA-14055; Txn markers should not be removed by matching records in the offset map
hachikuji opened a new pull request, #12390:
URL: https://github.com/apache/kafka/pull/12390
When cleaning a topic with transactional data, if the keys used in the user data happen to conflict with the keys in the transaction markers, it is possible for the markers to get removed before the corresponding data from the transaction is removed. This results in a hanging transaction or the loss of the transaction's atomicity since it would effectively get bundled into the. Currently control records are excluded when building the offset map, but not when doing the cleaning. This patch fixes the problem by checking for control batches in the `shouldRetainRecord` callback.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #12390: KAFKA-14055; Txn markers should not be removed by matching records in the offset map
Posted by GitBox <gi...@apache.org>.
hachikuji commented on PR #12390:
URL: https://github.com/apache/kafka/pull/12390#issuecomment-1179580222
@junrao Thanks for reviewing. The ARM agent has been a bit unreliable. It looks like the ARM node has been offline for a while. There is some discussion [here](https://github.com/apache/kafka/pull/12380/files) about removing it from the PR build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #12390: KAFKA-14055; Txn markers should not be removed by matching records in the offset map
Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12390:
URL: https://github.com/apache/kafka/pull/12390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org