You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by shivzone <gi...@git.apache.org> on 2016/09/20 00:28:57 UTC
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
GitHub user shivzone opened a pull request:
https://github.com/apache/incubator-hawq/pull/914
HAWQ-1045. RPM updates for side by side install/upgrade
https://issues.apache.org/jira/browse/HAWQ-1045
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shivzone/incubator-hawq HAWQ-1045
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/914.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #914
----
commit 330ad378fcebc904124c9bd25afa5764437da8da
Author: Shivram Mani <sh...@gmail.com>
Date: 2016-09-20T00:25:50Z
HAWQ-1045. RPM updates for side by side install/upgrade
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80308277
--- Diff: pxf/build.gradle ---
@@ -283,6 +287,28 @@ project('pxf-service') {
}
}
+project('pxf') {
+ jar.enabled = false
+ ospackage {
+ summary = 'HAWQ Extension Framework (PXF)'
+ description = 'HAWQ Extension framework Virtual RPM'
+ packager = ' '
+ packageGroup = 'Development/Libraries'
+ release = buildNumber() + '.' + project.osFamily
+ buildHost = ' '
+
+ requires(versionedPackageName('pxf-hdfs'), project.version, GREATER | EQUAL)
+ requires(versionedPackageName('pxf-hive'), project.version, GREATER | EQUAL)
+ requires(versionedPackageName('pxf-hbase'), project.version, GREATER | EQUAL)
+ requires(versionedPackageName('pxf-json'), project.version, GREATER | EQUAL)
+
+ link('/usr/lib/pxf', "/usr/lib/pxf-${project.version}")
+ link('/etc/pxf', "pxf-${project.version}")
--- End diff --
updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #914: HAWQ-1045. RPM updates for side by side install/u...
Posted by ljainpivotalio <gi...@git.apache.org>.
Github user ljainpivotalio commented on the issue:
https://github.com/apache/incubator-hawq/pull/914
pxf-json.rpm should be part of pxf-hdfs.rpm IMHO.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by mithmatt <gi...@git.apache.org>.
Github user mithmatt commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80140501
--- Diff: pxf/build.gradle ---
@@ -48,6 +48,12 @@ if (hddist != 'phd' && hddist != 'hdp') {
throw new GradleException("hadoop distribution parameter (hd) set to invalid value: $hddist")
}
+// Some package names need to be renamed to include the version number
+// as part of the package name to enable side by side install of two versions of the same package.
+def versionedPackageName(packageName) {
+ packageName + "_" + "${version}".replaceAll("-", "-")
--- End diff --
```
.replaceAll("-", "-")
```
This seems to be wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone closed the pull request at:
https://github.com/apache/incubator-hawq/pull/914
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80143517
--- Diff: pxf/settings.gradle ---
@@ -19,9 +19,10 @@
rootProject.name = 'pxf'
+include 'pxf'
--- End diff --
As pxf has dependencies on 'pxf-hdfs', 'pxf-hive', 'pxf-hbase', 'pxf-json' could we omit them in settings?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80143757
--- Diff: pxf/build.gradle ---
@@ -293,14 +316,15 @@ project('pxf-hdfs') {
}
ospackage {
+ packageName = versionedPackageName("${project.name}")
summary = 'HAWQ Extension Framework (PXF), HDFS plugin'
description = 'Querying external data stored in HDFS'
packager = ' '
packageGroup = 'Development/Libraries'
release = buildNumber() + '.' + project.osFamily
buildHost = ' '
- requires('pxf-service', project.version, GREATER | EQUAL)
+ requires(versionedPackageName('pxf-service'), project.version, GREATER | EQUAL)
requires('hadoop', "$hadoopVersion", GREATER | EQUAL)
--- End diff --
we are still not removing hadoop- dependencies ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80142540
--- Diff: pxf/build.gradle ---
@@ -283,6 +287,25 @@ project('pxf-service') {
}
}
+project('pxf') {
+ ospackage {
+ summary = 'HAWQ Extension Framework (PXF)'
+ description = 'HAWQ Extenstion framework'
--- End diff --
Extenstion - typo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80301161
--- Diff: pxf/build.gradle ---
@@ -283,6 +287,28 @@ project('pxf-service') {
}
}
+project('pxf') {
+ jar.enabled = false
+ ospackage {
+ summary = 'HAWQ Extension Framework (PXF)'
+ description = 'HAWQ Extension framework Virtual RPM'
+ packager = ' '
+ packageGroup = 'Development/Libraries'
+ release = buildNumber() + '.' + project.osFamily
+ buildHost = ' '
+
+ requires(versionedPackageName('pxf-hdfs'), project.version, GREATER | EQUAL)
+ requires(versionedPackageName('pxf-hive'), project.version, GREATER | EQUAL)
+ requires(versionedPackageName('pxf-hbase'), project.version, GREATER | EQUAL)
+ requires(versionedPackageName('pxf-json'), project.version, GREATER | EQUAL)
+
+ link('/usr/lib/pxf', "/usr/lib/pxf-${project.version}")
+ link('/etc/pxf', "pxf-${project.version}")
--- End diff --
no full path for "pxf-${project.version}" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80142923
--- Diff: pxf/build.gradle ---
@@ -283,6 +287,25 @@ project('pxf-service') {
}
}
+project('pxf') {
--- End diff --
Add comment that this rpm is virtual?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #914: HAWQ-1045. RPM updates for side by side install/u...
Posted by ljainpivotalio <gi...@git.apache.org>.
Github user ljainpivotalio commented on the issue:
https://github.com/apache/incubator-hawq/pull/914
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80143149
--- Diff: pxf/build.gradle ---
@@ -266,10 +273,7 @@ project('pxf-service') {
into '/opt/pivotal/pxf/tomcat-templates'
--- End diff --
line 259 -- dropping pxf-service into /etc/init.d would that conflict with side-by-side install ? should the script inside /etc/init.d be also a symlink ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80308625
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -22,8 +22,8 @@
pxf_root=/usr/lib/pxf
env_script=/etc/pxf/conf/pxf-env.sh
-tomcat_root=/opt/pivotal/apache-tomcat
-tomcat_templates=/opt/pivotal/pxf/tomcat-templates
+tomcat_root=/opt/apache-tomcat
+tomcat_templates=/opt/pxf/tomcat-templates
--- End diff --
Same holds true even for the library and conf paths as well being referenced in the classpath file (using their symlinks). Should be fine, as the expectation is that pxf would be installed using the virtual rpm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80293126
--- Diff: pxf/settings.gradle ---
@@ -19,9 +19,10 @@
rootProject.name = 'pxf'
+include 'pxf'
--- End diff --
settings.gradle must have every project included. Without which we would get the following error: Project with path 'pxf-service' could not be found in root project 'pxf'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80299815
--- Diff: pxf/build.gradle ---
@@ -283,6 +287,25 @@ project('pxf-service') {
}
}
+project('pxf') {
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80146264
--- Diff: pxf/build.gradle ---
@@ -48,6 +48,12 @@ if (hddist != 'phd' && hddist != 'hdp') {
throw new GradleException("hadoop distribution parameter (hd) set to invalid value: $hddist")
}
+// Some package names need to be renamed to include the version number
+// as part of the package name to enable side by side install of two versions of the same package.
+def versionedPackageName(packageName) {
+ packageName + "_" + "${version}".replaceAll("-", "-")
--- End diff --
My bad, will update this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80141800
--- Diff: pxf/build.gradle ---
@@ -48,6 +48,12 @@ if (hddist != 'phd' && hddist != 'hdp') {
throw new GradleException("hadoop distribution parameter (hd) set to invalid value: $hddist")
}
+// Some package names need to be renamed to include the version number
+// as part of the package name to enable side by side install of two versions of the same package.
+def versionedPackageName(packageName) {
+ packageName + "_" + "${version}".replaceAll("-", "-")
--- End diff --
should be .replaceAll(".", "_") ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80146788
--- Diff: pxf/build.gradle ---
@@ -293,14 +316,15 @@ project('pxf-hdfs') {
}
ospackage {
+ packageName = versionedPackageName("${project.name}")
summary = 'HAWQ Extension Framework (PXF), HDFS plugin'
description = 'Querying external data stored in HDFS'
packager = ' '
packageGroup = 'Development/Libraries'
release = buildNumber() + '.' + project.osFamily
buildHost = ' '
- requires('pxf-service', project.version, GREATER | EQUAL)
+ requires(versionedPackageName('pxf-service'), project.version, GREATER | EQUAL)
requires('hadoop', "$hadoopVersion", GREATER | EQUAL)
--- End diff --
The only decision we made was to remove dependancies on hbase and hive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/914#discussion_r80302210
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -22,8 +22,8 @@
pxf_root=/usr/lib/pxf
env_script=/etc/pxf/conf/pxf-env.sh
-tomcat_root=/opt/pivotal/apache-tomcat
-tomcat_templates=/opt/pivotal/pxf/tomcat-templates
+tomcat_root=/opt/apache-tomcat
+tomcat_templates=/opt/pxf/tomcat-templates
--- End diff --
/opt/pxf is a link established by VRPM, is that a problem ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---