[jira] [Comment Edited] (HIVE-16914) Change HiveMetaStoreClient to AutoCloseable

["Xiaomeng Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-16914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057976#comment-16057976 ] 

Xiaomeng Zhang edited comment on HIVE-16914 at 6/21/17 6:26 PM:
----------------------------------------------------------------

I run test org.apache.hive.jdbc.TestJdbcWithMiniHS2.testHttpRetryOnServerIdleTimeout locally and it can pass.

{code:java}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hive.jdbc.TestJdbcWithMiniHS2
Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 107.34 sec - in org.apache.hive.jdbc.TestJdbcWithMiniHS2
Results :
Tests run: 26, Failures: 0, Errors: 0, Skipped: 0
{code}
And took a look at newest preCommit build, this test also fails, seems to be a flaky one.
https://builds.apache.org/job/PreCommit-HIVE-Build/5717/#showFailuresLink


was (Author: xiaomeng zhang):
I run test org.apache.hive.jdbc.TestJdbcWithMiniHS2.testHttpRetryOnServerIdleTimeout locally and it can pass.

{code:java}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hive.jdbc.TestJdbcWithMiniHS2
Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 107.34 sec - in org.apache.hive.jdbc.TestJdbcWithMiniHS2
Results :
Tests run: 26, Failures: 0, Errors: 0, Skipped: 0
{code}
And looks newest preCommit build, this test also fails, seems to be a flaky one.
https://builds.apache.org/job/PreCommit-HIVE-Build/5717/#showFailuresLink

> Change HiveMetaStoreClient to AutoCloseable
> -------------------------------------------
>
>                 Key: HIVE-16914
>                 URL: https://issues.apache.org/jira/browse/HIVE-16914
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Xiaomeng Zhang
>            Assignee: Xiaomeng Zhang
>            Priority: Trivial
>         Attachments: HIVE-16914.01.patch
>
>
> During my usage of HiveMetaStoreClient for testing, I found that this class is not AutoCloseable. Adding this change to support 
> try(HiveMetaStoreClient hmsClient = HiveEnv.createHMSClient()) {
> ...
> ...
> ...
> ...
> }
> So we don't have to manually close it in finally block.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)