You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2021/11/23 05:26:00 UTC

[jira] [Commented] (LUCENE-10252) ValueSource.asDoubleValues shouldn't fetch score

    [ https://issues.apache.org/jira/browse/LUCENE-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447782#comment-17447782 ] 

David Smiley commented on LUCENE-10252:
---------------------------------------

I commented out putting the "scorer" key in this map and Lucene & Solr tests pass.  If we don't even have tests that exercise this, I wonder why this was added in the first place?  CC [~romseygeek] 

> ValueSource.asDoubleValues shouldn't fetch score
> ------------------------------------------------
>
>                 Key: LUCENE-10252
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10252
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/query
>            Reporter: David Smiley
>            Priority: Major
>
> The ValueSource.asDoubleValuesSource() method bridges the old API to the new one.  It's rather important because boosting a query no longer has an old API; in its place is using this method and passing to FunctionScoreQuery.boostByValue.  Unfortunately, asDoubleValuesSource will fetch/compute the score for the document in order to expose it in a Scorable on the "scorer" key of the context Map.  AFAICT nothing in Lucene or Solr actually uses this.  If it should be kept, the Scorable's score() method could fetch it at that time (e.g. on-demand).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org