You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/19 15:37:51 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #11904: Refactor use iterator to visit LinkedList in shadow project.

codecov-commenter commented on pull request #11904:
URL: https://github.com/apache/shardingsphere/pull/11904#issuecomment-902017876


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11904?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11904](https://codecov.io/gh/apache/shardingsphere/pull/11904?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9386eff) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5882dada45835a51c35919d4f01695ffb9bbbf94?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5882dad) will **increase** coverage by `0.02%`.
   > The diff coverage is `40.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11904/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11904      +/-   ##
   ============================================
   + Coverage     62.91%   62.94%   +0.02%     
   + Complexity     1217     1209       -8     
   ============================================
     Files          2297     2296       -1     
     Lines         34962    34974      +12     
     Branches       6087     6093       +6     
   ============================================
   + Hits          21996    22013      +17     
   + Misses        11180    11173       -7     
   - Partials       1786     1788       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ator/impl/ShadowPredicateColumnTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9TaGFkb3dQcmVkaWNhdGVDb2x1bW5Ub2tlbkdlbmVyYXRvci5qYXZh) | `6.06% <4.76%> (+0.34%)` | :arrow_up: |
   | [...nerator/impl/ShadowInsertColumnTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9TaGFkb3dJbnNlcnRDb2x1bW5Ub2tlbkdlbmVyYXRvci5qYXZh) | `73.91% <66.66%> (-1.09%)` | :arrow_down: |
   | [...nerator/impl/ShadowUpdateColumnTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9TaGFkb3dVcGRhdGVDb2x1bW5Ub2tlbkdlbmVyYXRvci5qYXZh) | `77.77% <78.57%> (+14.14%)` | :arrow_up: |
   | [...trics/prometheus/collector/ProxyInfoCollector.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tbWV0cmljcy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvcHJvbWV0aGV1cy9jb2xsZWN0b3IvUHJveHlJbmZvQ29sbGVjdG9yLmphdmE=) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
   | [...try/state/watcher/TerminalStateChangedWatcher.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9zdGF0ZS93YXRjaGVyL1Rlcm1pbmFsU3RhdGVDaGFuZ2VkV2F0Y2hlci5qYXZh) | `50.00% <0.00%> (ø)` | |
   | [...sphere/proxy/frontend/state/ProxyStateContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvc3RhdGUvUHJveHlTdGF0ZUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../governance/internal/state/impl/OKDriverState.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWdvdmVybmFuY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9nb3Zlcm5hbmNlL2ludGVybmFsL3N0YXRlL2ltcGwvT0tEcml2ZXJTdGF0ZS5qYXZh) | | |
   | [...g/apache/shardingsphere/infra/state/StateType.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zdGF0ZS9TdGF0ZVR5cGUuamF2YQ==) | | |
   | [...e/internal/state/impl/CircuitBreakDriverState.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWdvdmVybmFuY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9nb3Zlcm5hbmNlL2ludGVybmFsL3N0YXRlL2ltcGwvQ2lyY3VpdEJyZWFrRHJpdmVyU3RhdGUuamF2YQ==) | | |
   | [.../governance/internal/state/DriverStateContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWdvdmVybmFuY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9nb3Zlcm5hbmNlL2ludGVybmFsL3N0YXRlL0RyaXZlclN0YXRlQ29udGV4dC5qYXZh) | | |
   | ... and [8 more](https://codecov.io/gh/apache/shardingsphere/pull/11904/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11904?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11904?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5882dad...9386eff](https://codecov.io/gh/apache/shardingsphere/pull/11904?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org