[GitHub] [incubator-echarts] SnailSword commented on pull request #13317: [5.0] [Feature] support largest-triangle-three-buckets algo

[GitBox <gi...@apache.org>]

SnailSword commented on pull request #13317:
URL: https://github.com/apache/incubator-echarts/pull/13317#issuecomment-696867171


   > Also, do you mind adding a test case to compare the result and performance difference between lttb sampling enabled and disabled?
   > 
   > The example used in [#13314 (comment)](https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284) will be a good case.
   > 
   
   ![demo](https://user-images.githubusercontent.com/19756301/93916339-f4ca0700-fd3b-11ea-8f38-adb820bd78b6.gif)
   
   
   @pissang Thank you for your advise. I added comparison of results in `test/sample-compare.html`. But I don't know how to compare the performance, time spent on this part(the pic below) is almost the same in each downsampling method, and also same as that without downsampling. I don't think it is the correct way to compare the performance.
   
   ![image](https://user-images.githubusercontent.com/19756301/93914843-b0d60280-fd39-11ea-9ca5-59853ac9667d.png)
   
   
   
   > And there are some code style like inconsistent indentation needs to be fixed.
   
   Fixed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org