You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apiri <gi...@git.apache.org> on 2018/06/25 20:32:35 UTC
[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/130
MINIFI-441 Update Docker configuration and documentation
MINIFI-441 Update versions to reflect next release.
Adding tailing of the minifi process in the Dockerfile and updating documentation on how to make use of the Docker image.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi MINIFI-441
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit f272355ce1924f6d7befda4b83437f1a9b1a71e7
Author: Aldrin Piri <al...@...>
Date: 2018-06-25T18:36:35Z
MINIFI-441 Update versions to reflect next release.
Adding tailing of the minifi process in the Dockerfile and updating documentation on how to make use of the Docker image.
----
---
[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...
Posted by jzonthemtn <gi...@git.apache.org>.
Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/130#discussion_r197939298
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
RUN apk --no-cache add curl
+ADD sh/ ${MINIFI_BASE_DIR}/scripts/
--- End diff --
Noticed below it's used as just `$MINIFI_BASE_DIR`. Is the `{}` needed?
---
[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi/pull/130
---
[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/130#discussion_r197971051
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
RUN apk --no-cache add curl
+ADD sh/ ${MINIFI_BASE_DIR}/scripts/
--- End diff --
Either format is valid, and in this case, equivalent.
From the [POSIX spec](http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02):
> The simplest form for parameter expansion is:
>
> ${parameter}
>
> The value, if any, of parameter shall be substituted.
>
> The parameter name or symbol can be enclosed in braces, which are optional... If the parameter is not enclosed in braces, and is a name, the expansion shall use the longest valid name
---
[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/130#discussion_r197976141
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
RUN apk --no-cache add curl
+ADD sh/ ${MINIFI_BASE_DIR}/scripts/
--- End diff --
Fair point. It also occurred to me later that I'm not sure if Dockerfile syntax has any special interpretation / side-effect that differs for POSIX... of that I'm not positive but in any case it seems to work ok :)
---
[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...
Posted by jzonthemtn <gi...@git.apache.org>.
Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/130#discussion_r197976891
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
RUN apk --no-cache add curl
+ADD sh/ ${MINIFI_BASE_DIR}/scripts/
--- End diff --
I know I can be a nitpicker sometimes on pull requests just to try to bring stuff to attention to make sure it's what was intended. :) I have used `$VAR` but I don't think I have ever used `${VAR}` in a Dockerfile.
---
[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...
Posted by jzonthemtn <gi...@git.apache.org>.
Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/130#discussion_r197975719
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
RUN apk --no-cache add curl
+ADD sh/ ${MINIFI_BASE_DIR}/scripts/
--- End diff --
Wondering more from a consistency aspect but I don't think it matters. Thanks!
---
[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/130#discussion_r197978101
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
RUN apk --no-cache add curl
+ADD sh/ ${MINIFI_BASE_DIR}/scripts/
--- End diff --
I was curious and looked it up as well. I found the correct answer for Dockerfile syntax here: https://docs.docker.com/engine/reference/builder/#environment-replacement
> Environment variables are notated in the Dockerfile either with $variable_name or ${variable_name}. They are treated equivalently and the brace syntax is typically used to address issues with variable names with no whitespace, like ${foo}_bar
Good eye, and I agree it's always better to point something out on reviews. Everyone sees things slightly differently, and even if "correct" functionally, it may not be the author's intention. Thanks!
---