[jira] [Commented] (THRIFT-3025) Change pure Int constants into @enums (where possible)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349666#comment-14349666 ] 

ASF GitHub Bot commented on THRIFT-3025:
----------------------------------------

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/391

    THRIFT-3025 Change pure Ints into @enums

    Client: Haxe
    Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-3025-haxe-enums

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #391
    
----
commit 1a5fe7f73501280568da18ed265d4ec361966b94
Author: Jens Geyer <je...@apache.org>
Date:   2015-03-05T22:11:45Z

    THRIFT-3025 Change pure Ints into @enums
    Client: Haxe
    Patch: Jens Geyer

----


> Change pure Int constants into @enums (where possible)
> ------------------------------------------------------
>
>                 Key: THRIFT-3025
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3025
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Haxe - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.9.3
>
>
> There are a few places where numeric constants should be represented as {{@enums}} instead of Ints. 
> *Important note:* This is not possible now in all cases [because of a restriction with Haxe 3.1.3|https://github.com/HaxeFoundation/haxe/issues/3649] which essentially prevents the handling of enum values that are unknown at compile time. Thus, enum values that may be subject to further expansion (such as exception codes) should not be converted unless Haxe 3.1.3 support is dropped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)