You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by David Harris <dh...@drh.net> on 1999/08/15 07:33:49 UTC
[patch] make does not propagate src/support errors
I've run into a problem where build errors caught in the src/support/Makefile
do not properly stop the top level Makefile from continuing and reporting a
successful build. This is because the return value from calling make for
src/support is not being properly checked. Attached is a patch to fix this.
Then I discovered other places in the Makefile that appear to have the same
problem, so I've attached a separate patch for them.
apache_1.3.6_makefile_error1.patch = fix for src/support error passing
apache_1.3.6_makefile_error2.patch = fix for other suspected error passing
problems
If this is on track, I can go looking through the other Makefile.tmpl's looking
for the same problem. But I'll hold off on doing that until I hear something.
- David Harris
Principal Engineer, DRH Internet Services
RE: [patch] make does not propagate src/support errors
Posted by David Harris <dh...@drh.net>.
Arrroughh.. last patches were also messed up. I feel like such a fool.
Okay, this one I've tested more than just "oh, the build stops at the right
point.. that's good".
Lessons learned:
(1) Test even simple things really, really thoroughly.
(2) Don't rush fixes out the door so fast that you forget to do thorough
testing.
- David Harris
Principal Engineer, DRH Internet Services
RE: [patch] make does not propagate src/support errors
Posted by David Harris <dh...@drh.net>.
Whoops.. stupid mistake. Use these patches, not the ones from my previous
e-mail.
- David Harris
Principal Engineer, DRH Internet Services