You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/02/06 13:09:08 UTC

[GitHub] jiangphcn opened a new pull request #1143: Remove queries for _all_docs, _design_docs and _local_docs

jiangphcn opened a new pull request #1143: Remove queries for _all_docs,  _design_docs and _local_docs
URL: https://github.com/apache/couchdb/pull/1143
 
 
   
   
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   In the https://github.com/apache/couchdb/pull/1032, queries are supported to `_all_docs`, `_design_docs` and `_local_docs` to address the requirement in https://github.com/apache/couchdb/issues/820.
   However, the response schema changes depending on what is POSTed. This makes it quite hard to interact with from static type languages. So we plan to move the implementation to separate endpoint. As the first step, this PR is used to remove queries for _all_docs,  _design_docs and _local_docs.
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   make check skip_deps+=couch_epi apps=chttpd tests=all_test_
   ```
   ==> chttpd (eunit)
   Compiled test/chttpd_db_test.erl
   Compiled src/chttpd_db.erl
       Running test function(s):
         chttpd_db_doc_size_tests:all_test_/0
         chttpd_db_test:all_test_/0
         chttpd_security_tests:all_test_/0
   ======================== EUnit ========================
   chttpd security tests
   Application crypto was left running!
     chttpd_security_tests:120: should_allow_admin_db_compaction...[0.003 s] ok
     chttpd_security_tests:137: should_allow_valid_password_to_create_user...ok
     chttpd_security_tests:147: should_disallow_invalid_password_to_create_user...ok
     chttpd_security_tests:155: should_disallow_anonymous_db_compaction...ok
     chttpd_security_tests:163: should_disallow_db_member_db_compaction...ok
     chttpd_security_tests:166: should_allow_db_admin_db_compaction...[0.002 s] ok
     chttpd_security_tests:176: should_allow_admin_view_compaction...[0.009 s] ok
     chttpd_security_tests:191: should_disallow_anonymous_view_compaction...ok
     chttpd_security_tests:194: should_allow_admin_db_view_cleanup...[0.002 s] ok
     chttpd_security_tests:209: should_disallow_anonymous_db_view_cleanup...ok
   [os_mon] cpu supervisor port (cpu_sup): Erlang has closed
     [done in 5.346 s]
   chttpd db tests
     chttpd_db_test:81: should_return_ok_true_on_bulk_update...[0.048 s] ok
     chttpd_db_test:108: should_accept_live_as_an_alias_for_continuous...[0.034 s] ok
     chttpd_db_test:123: should_return_404_for_delete_att_on_notadoc...[0.005 s] ok
     chttpd_db_test:145: should_return_409_for_del_att_without_rev...[0.040 s] ok
     chttpd_db_test:163: should_return_200_for_del_att_with_rev...[0.061 s] ok
     chttpd_db_test:184: should_return_409_for_put_att_nonexistent_rev...[0.010 s] ok
     chttpd_db_test:199: should_return_update_seq_when_set_on_all_docs...[0.134 s] ok
     chttpd_db_test:213: should_not_return_update_seq_when_unset_on_all_docs...[0.077 s] ok
     chttpd_db_test:227: should_return_correct_id_on_doc_copy...[0.086 s] ok
   [os_mon] cpu supervisor port (cpu_sup): Erlang has closed
     [done in 2.029 s]
   chttpd db max_document_size tests
     chttpd_db_doc_size_tests:84: post_single_doc...ok
     chttpd_db_doc_size_tests:92: put_single_doc...ok
     chttpd_db_doc_size_tests:101: bulk_doc...ok
     chttpd_db_doc_size_tests:127: put_post_doc_attach_inline...ok
     chttpd_db_doc_size_tests:128: put_post_doc_attach_inline...ok
     chttpd_db_doc_size_tests:129: put_post_doc_attach_inline...ok
     chttpd_db_doc_size_tests:130: put_post_doc_attach_inline...ok
     chttpd_db_doc_size_tests:152: put_multi_part_related...ok
     chttpd_db_doc_size_tests:153: put_multi_part_related...ok
     chttpd_db_doc_size_tests:177: post_multi_part_form...ok
     chttpd_db_doc_size_tests:178: post_multi_part_form...ok
   [os_mon] cpu supervisor port (cpu_sup): Erlang has closed
     [done in 1.162 s]
   =======================================================
     All 30 tests passed.
   ```
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   https://github.com/apache/couchdb/issues/820
   https://github.com/apache/couchdb/pull/1032
   
   ## Checklist
   
   - [X] Code is written and works correctly;
   - [X] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services