You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/10/11 20:35:00 UTC

[jira] [Commented] (IMPALA-11610) Dockerized tests don't respect Jenkins parameters / environment variables

    [ https://issues.apache.org/jira/browse/IMPALA-11610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616067#comment-17616067 ] 

ASF subversion and git services commented on IMPALA-11610:
----------------------------------------------------------

Commit 72812c5955a23c9270008e8371d8585d5165a27d in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=72812c595 ]

IMPALA-11610: Pass environment variables into dockerized-impala-run-tests.sh

Because dockerized-impala-bootstrap-test.sh does a relogin while
calling dockerized-impala-run-tests.sh, the environment is not
preserved.

This adds a script dockerized-impala-preserve-vars.py that takes
a list of environment variables to preserve and appends
export statements to bin/impala-config-local.sh. Since
dockerized-impala-run-tests.sh sources bin/impala-config.sh, these
variables will be carried into the test execution.

This starts by adding environment variables used by upstream
Jenkin's ubuntu-16.04-dockerized-tests. Jenkins jobs can also
call dockerized-impala-preserve-vars.py directly.

Testing:
 - Hand tested the preservation script
 - Verified ubuntu-16.04-dockerized-tests now respected EE_TEST
   argument.

Change-Id: I325217c731883c087c724194b45d50b790c7c280
Reviewed-on: http://gerrit.cloudera.org:8080/19088
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>


> Dockerized tests don't respect Jenkins parameters / environment variables
> -------------------------------------------------------------------------
>
>                 Key: IMPALA-11610
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11610
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 4.2.0
>            Reporter: Joe McDonnell
>            Priority: Major
>
> In testing the dockerized Jenkins jobs on jenkins.impala.io, I noticed that the Jenkins arguments are ignored. It turns out the environment variables are not getting passed from bin/jenkins/dockerized-impala-bootstrap-and-test.sh to bin/jenkins/dockerized-impala-run-tests.sh.
> For example, if I uncheck the EE_TEST option on ubuntu-16.04-dockerised-tests, it still runs end to end tests.
> Respecting these arguments would be useful for adding the ability to test with Java 11. If we can specify whether to use Java 11 via a parameter, then we can share the job with the regular Java 8 version.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org