You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hiboyang (via GitHub)" <gi...@apache.org> on 2023/08/04 18:43:48 UTC
[GitHub] [spark-connect-go] hiboyang opened a new pull request, #14: [SPARK-44681] Fix issues when writing Go application code using Spark Connect Go client library
hiboyang opened a new pull request, #14:
URL: https://github.com/apache/spark-connect-go/pull/14
### What changes were proposed in this pull request?
When trying to write Go application code using Spark Connect Go client and put the Go application code in users' own repo (e.g. https://github.com/user-foo/my-go-application), the Go application code cannot resolve Spark Connect Go client from `https://github.com/apache/spark-connect-go` correctly, due to two issues:
1. The name `github.com/apache/spark-connect-go/v_3_4` cannot resolve correctly to find the module, it complains not finding `go.mod` file under `github.com/apache/spark-connect-go/v_3_4`. After change the name to `github.com/apache/spark-connect-go/v34`, it is good.
2. The Go application code needs generated Go protobuf code as well. Thus need to commit the generated Go protobuf code into `github.com/apache/spark-connect-go` repo.
### Why are the changes needed?
See above.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested by run Go application code to use Spark Connect Go client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-connect-go] hiboyang commented on a diff in pull request #14: [SPARK-44681] Fix issues when writing Go application code using Spark Connect Go client library
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on code in PR #14:
URL: https://github.com/apache/spark-connect-go/pull/14#discussion_r1290396292
##########
go.mod:
##########
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-module github.com/apache/spark-connect-go/v_3_4
+module github.com/apache/spark-connect-go/v34
Review Comment:
Thanks for reviewing! Yeah, previously we have code inside this repo referencing this same library , thus `v_3_4` does not cause problem. When I wrote another Go application outside of this repo, referencing this repo as a library, then got issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-connect-go] grundprinzip commented on a diff in pull request #14: [SPARK-44681] Fix issues when writing Go application code using Spark Connect Go client library
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #14:
URL: https://github.com/apache/spark-connect-go/pull/14#discussion_r1290120465
##########
go.mod:
##########
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-module github.com/apache/spark-connect-go/v_3_4
+module github.com/apache/spark-connect-go/v34
Review Comment:
it's interesting that this hasn't caused issues before really. But I'm fine with the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-connect-go] hiboyang commented on pull request #14: [SPARK-44681] Fix issues when writing Go application code using Spark Connect Go client library
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on PR #14:
URL: https://github.com/apache/spark-connect-go/pull/14#issuecomment-1670515501
This PR is mostly generated code like `internal/generated/base.pb.go`, `internal/generated/base_grpc.pb.go`, etc. We need to put those files into this repo so other Go application could reference this repo as a Go library properly.
Please ignore those generated code. Except those code, the PR is actually small :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-connect-go] hiboyang commented on pull request #14: [SPARK-44681] Fix issues when writing Go application code using Spark Connect Go client library
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on PR #14:
URL: https://github.com/apache/spark-connect-go/pull/14#issuecomment-1666038953
@HyukjinKwon @grundprinzip @zhengruifeng I find some issues when I write a standalone Spark Connect application using this spark-connect-go repo as a library. The PR is to fix these issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-connect-go] zhengruifeng closed pull request #14: [SPARK-44681] Fix issues when writing Go application code using Spark Connect Go client library
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #14: [SPARK-44681] Fix issues when writing Go application code using Spark Connect Go client library
URL: https://github.com/apache/spark-connect-go/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-connect-go] zhengruifeng commented on pull request #14: [SPARK-44681] Fix issues when writing Go application code using Spark Connect Go client library
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #14:
URL: https://github.com/apache/spark-connect-go/pull/14#issuecomment-1683332220
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-connect-go] hiboyang commented on a diff in pull request #14: [SPARK-44681] Fix issues when writing Go application code using Spark Connect Go client library
Posted by "hiboyang (via GitHub)" <gi...@apache.org>.
hiboyang commented on code in PR #14:
URL: https://github.com/apache/spark-connect-go/pull/14#discussion_r1290396292
##########
go.mod:
##########
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-module github.com/apache/spark-connect-go/v_3_4
+module github.com/apache/spark-connect-go/v34
Review Comment:
Thanks for reviewing! Yeah, previously we reference the code inside this repo, thus `v_3_4` does not cause problem. When I wrote another Go application outside of this repo, referencing this repo as a library, then got issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org