You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/02 16:38:48 UTC
[GitHub] [incubator-dolphinscheduler] Yeleights opened a new pull request
#1690: fix sonar bug: null check & clean throw exception
Yeleights opened a new pull request #1690: fix sonar bug: null check & clean throw exception
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1690
## What is the purpose of the pull request
*fix sonar bug: null check & clean throw exception*
## Brief change log
- *fix null check*
- *clean throw exception*
## Verify this pull request
This pull request is code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1690: fix sonar bug: null check & clean throw exception
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1690: fix sonar bug: null check & clean throw exception
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1690#issuecomment-570264682
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`dev@a80e902`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1690 +/- ##
======================================
Coverage ? 17.21%
======================================
Files ? 284
Lines ? 13853
Branches ? 2255
======================================
Hits ? 2385
Misses ? 11193
Partials ? 275
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...inscheduler/common/job/db/DB2ServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9EQjJTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <ø> (ø)` | |
| [...nscheduler/common/job/db/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9DbGlja0hvdXNlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | |
| [...he/dolphinscheduler/common/model/DateInterval.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL0RhdGVJbnRlcnZhbC5qYXZh) | `20% <ø> (ø)` | |
| [...inscheduler/common/job/db/SQLServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9TUUxTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <ø> (ø)` | |
| [...lphinscheduler/common/job/db/OracleDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9PcmFjbGVEYXRhU291cmNlLmphdmE=) | `0% <ø> (ø)` | |
| [...dolphinscheduler/common/job/db/HiveDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9IaXZlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | |
| [...phinscheduler/common/job/db/PostgreDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9Qb3N0Z3JlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | |
| [...olphinscheduler/common/model/TaskNodeRelation.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlUmVsYXRpb24uamF2YQ==) | `0% <ø> (ø)` | |
| [...dolphinscheduler/common/utils/ConnectionUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0Nvbm5lY3Rpb25VdGlscy5qYXZh) | `0% <ø> (ø)` | |
| [...olphinscheduler/common/job/db/SparkDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9TcGFya0RhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=footer). Last update [a80e902...506b94d](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1690:
fix sonar bug: null check & clean throw exception
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1690: fix sonar bug: null check & clean throw exception
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1690:
fix sonar bug: null check & clean throw exception
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1690: fix sonar bug: null check & clean throw exception
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1690#issuecomment-570264682
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=h1) Report
> Merging [#1690](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/26ed786c4d4cd1b8ae0e49a4a2ac7f2677a1948a?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1690 +/- ##
=========================================
+ Coverage 16.3% 16.31% +<.01%
=========================================
Files 283 283
Lines 13864 13860 -4
Branches 2251 2258 +7
=========================================
Hits 2261 2261
+ Misses 11343 11339 -4
Partials 260 260
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...inscheduler/common/job/db/DB2ServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9EQjJTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...nscheduler/common/job/db/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9DbGlja0hvdXNlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...inscheduler/common/job/db/SQLServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9TUUxTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...lphinscheduler/common/job/db/OracleDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9PcmFjbGVEYXRhU291cmNlLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...dolphinscheduler/common/job/db/HiveDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9IaXZlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...phinscheduler/common/job/db/PostgreDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9Qb3N0Z3JlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...dolphinscheduler/common/utils/ConnectionUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0Nvbm5lY3Rpb25VdGlscy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...olphinscheduler/common/job/db/SparkDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9TcGFya0RhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...olphinscheduler/common/job/db/MySQLDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9NeVNRTERhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=footer). Last update [26ed786...d3b6da9](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1690?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services