You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/17 15:28:49 UTC
[GitHub] [doris] morningman opened a new pull request, #16033: [fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue
morningman opened a new pull request, #16033:
URL: https://github.com/apache/doris/pull/16033
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16033: [fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16033:
URL: https://github.com/apache/doris/pull/16033#issuecomment-1386687404
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16033: [fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #16033:
URL: https://github.com/apache/doris/pull/16033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16033: [fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16033:
URL: https://github.com/apache/doris/pull/16033#issuecomment-1385985800
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.56 seconds
load time: 522 seconds
storage size: 17121900929 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230117200542_clickbench_pr_82622.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #16033: [fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #16033:
URL: https://github.com/apache/doris/pull/16033#discussion_r1073091050
##########
fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java:
##########
@@ -248,9 +248,11 @@ private void init(String driverUrl, String sql, int batchSize, String driverClas
dataSource = new HikariDataSource(config);
conn = dataSource.getConnection();
+ conn.setAutoCommit(false);
if (op == TJdbcOperation.READ) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangstar333 commented on a diff in pull request #16033: [fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue
Posted by GitBox <gi...@apache.org>.
zhangstar333 commented on code in PR #16033:
URL: https://github.com/apache/doris/pull/16033#discussion_r1073016535
##########
fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java:
##########
@@ -248,9 +248,11 @@ private void init(String driverUrl, String sql, int batchSize, String driverClas
dataSource = new HikariDataSource(config);
conn = dataSource.getConnection();
+ conn.setAutoCommit(false);
if (op == TJdbcOperation.READ) {
Review Comment:
should set it to false only the op==READ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16033: [fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16033:
URL: https://github.com/apache/doris/pull/16033#issuecomment-1386687338
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org