You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2015/06/18 12:19:02 UTC

[jira] [Comment Edited] (PROTON-915) Incompatible protocol header handled incorrectly

    [ https://issues.apache.org/jira/browse/PROTON-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591604#comment-14591604 ] 

Robbie Gemmell edited comment on PROTON-915 at 6/18/15 10:18 AM:
-----------------------------------------------------------------

To be clear, I'm only really discussing the server side above. The client sending things after the header seems entirely permissable by what the spec says (and I think that is likely what the statement in Gordons first quote is there to allow).


was (Author: gemmellr):
o be clear, I'm only really discussing the server side above. The client sending things after the header seems entirely permissable by what the spec says (and I think that is likely what the statement in Gordons first quote is there to allow).

> Incompatible protocol header handled incorrectly
> ------------------------------------------------
>
>                 Key: PROTON-915
>                 URL: https://issues.apache.org/jira/browse/PROTON-915
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.9, 0.9.1
>            Reporter: Gordon Sim
>            Assignee: Rafael H. Schloming
>            Priority: Blocker
>             Fix For: 0.10
>
>         Attachments: 0001-PROTON-915-Send-correct-AMQP-header-upon-protocol-mi.patch
>
>
> The correct response is to send back a supported header[1] before closing the socket. This worked for 0.8 but is broker from 0.9 onwards, I believe by this commit: https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;a=commit;h=1b2be03c748ef5a57cf181f8373b9b6e8f8cfd22
> It means anything relying on proton-c for protocol header handling is not compliant with the spec.
> [1]  section 2.2 of spec: "If the requested protocol version is not supported, the server MUST send a protocol header with a supported protocol version and then close the socket." 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)