You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2021/04/27 21:49:04 UTC

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell 

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17351


Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................

POC: use puresasl instead of sasl in impala-shell

There are plans to switch to puresasl in Impyla:
https://github.com/attilajeges/thrift_sasl/commit/c95c69a041d89aa7963f4f9d3834d8e347cf05af

This change tries to do the same in Impala to be
able to run Impala's test suite with puresasl.

Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M shell/.gitignore
A shell/ext-py/pure-sasl-0.6.2/CHANGES.rst
A shell/ext-py/pure-sasl-0.6.2/LICENSE
A shell/ext-py/pure-sasl-0.6.2/MANIFEST.in
A shell/ext-py/pure-sasl-0.6.2/PKG-INFO
A shell/ext-py/pure-sasl-0.6.2/README.rst
A shell/ext-py/pure-sasl-0.6.2/puresasl/__init__.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/client.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/mechanisms.py
A shell/ext-py/pure-sasl-0.6.2/setup.cfg
A shell/ext-py/pure-sasl-0.6.2/setup.py
D shell/ext-py/sasl-0.2.1/LICENSE.txt
D shell/ext-py/sasl-0.2.1/MANIFEST.in
D shell/ext-py/sasl-0.2.1/recython.sh
D shell/ext-py/sasl-0.2.1/sasl/__init__.py
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.cpp
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.h
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.pyx
D shell/ext-py/sasl-0.2.1/setup.py
M shell/ext-py/thrift_sasl-0.4.2/setup.py
M shell/impala-shell
M shell/impala_client.py
24 files changed, 1,128 insertions(+), 5,069 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17351/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17351

to look at the new patch set (#4).

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................

POC: use puresasl instead of sasl in impala-shell

There are plans to switch to puresasl in Impyla:
https://github.com/attilajeges/thrift_sasl/commit/c95c69a041d89aa7963f4f9d3834d8e347cf05af

This change tries to do the same in Impala to be
able to run Impala's test suite with puresasl.

Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M bin/run-workload.py
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/pure-sasl-0.6.2/CHANGES.rst
A shell/ext-py/pure-sasl-0.6.2/LICENSE
A shell/ext-py/pure-sasl-0.6.2/MANIFEST.in
A shell/ext-py/pure-sasl-0.6.2/PKG-INFO
A shell/ext-py/pure-sasl-0.6.2/README.rst
A shell/ext-py/pure-sasl-0.6.2/puresasl/__init__.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/client.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/mechanisms.py
A shell/ext-py/pure-sasl-0.6.2/setup.cfg
A shell/ext-py/pure-sasl-0.6.2/setup.py
D shell/ext-py/sasl-0.2.1/LICENSE.txt
D shell/ext-py/sasl-0.2.1/MANIFEST.in
D shell/ext-py/sasl-0.2.1/recython.sh
D shell/ext-py/sasl-0.2.1/sasl/__init__.py
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.cpp
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.h
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.pyx
D shell/ext-py/sasl-0.2.1/setup.py
M shell/ext-py/thrift_sasl-0.4.2/setup.py
M shell/impala-shell
M shell/impala_client.py
A shell/impala_sasl_compat.py
M shell/make_shell_tarball.sh
A tests/util/impala_sasl_compat.py
M tests/util/thrift_util.py
30 files changed, 1,270 insertions(+), 5,092 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17351/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8663/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 17:40:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 7:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/17351/7/bin/run-workload.py
File bin/run-workload.py:

http://gerrit.cloudera.org:8080/#/c/17351/7/bin/run-workload.py@223
PS7, Line 223: i
flake8: F401 'puresasl' imported but unused


http://gerrit.cloudera.org:8080/#/c/17351/7/shell/impala_sasl_compat.py
File shell/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/7/shell/impala_sasl_compat.py@18
PS7, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/7/shell/impala_sasl_compat.py@23
PS7, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/7/shell/impala_sasl_compat.py@24
PS7, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/7/shell/impala_sasl_compat.py@24
PS7, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/7/tests/util/impala_sasl_compat.py
File tests/util/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/7/tests/util/impala_sasl_compat.py@18
PS7, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/7/tests/util/impala_sasl_compat.py@23
PS7, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/7/tests/util/impala_sasl_compat.py@24
PS7, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/7/tests/util/impala_sasl_compat.py@24
PS7, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals



-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 May 2021 14:11:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8721/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 May 2021 07:58:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7110/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 13:08:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7110/


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 13:22:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 5:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/17351/5/bin/run-workload.py
File bin/run-workload.py:

http://gerrit.cloudera.org:8080/#/c/17351/5/bin/run-workload.py@223
PS5, Line 223: i
flake8: F401 'puresasl' imported but unused


http://gerrit.cloudera.org:8080/#/c/17351/5/shell/impala_sasl_compat.py
File shell/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/5/shell/impala_sasl_compat.py@18
PS5, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/5/shell/impala_sasl_compat.py@23
PS5, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/5/shell/impala_sasl_compat.py@24
PS5, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/5/shell/impala_sasl_compat.py@24
PS5, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/5/tests/util/impala_sasl_compat.py
File tests/util/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/5/tests/util/impala_sasl_compat.py@18
PS5, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/5/tests/util/impala_sasl_compat.py@23
PS5, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/5/tests/util/impala_sasl_compat.py@24
PS5, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/5/tests/util/impala_sasl_compat.py@24
PS5, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals



-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 17:16:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17351

to look at the new patch set (#8).

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................

POC: use puresasl instead of sasl in impala-shell

There are plans to switch to puresasl in Impyla:
https://github.com/attilajeges/thrift_sasl/commit/c95c69a041d89aa7963f4f9d3834d8e347cf05af

This change tries to do the same in Impala to be
able to run Impala's test suite with puresasl.

Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M bin/run-workload.py
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/pure-sasl-0.6.2/CHANGES.rst
A shell/ext-py/pure-sasl-0.6.2/LICENSE
A shell/ext-py/pure-sasl-0.6.2/MANIFEST.in
A shell/ext-py/pure-sasl-0.6.2/PKG-INFO
A shell/ext-py/pure-sasl-0.6.2/README.rst
A shell/ext-py/pure-sasl-0.6.2/puresasl/__init__.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/client.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/mechanisms.py
A shell/ext-py/pure-sasl-0.6.2/setup.cfg
A shell/ext-py/pure-sasl-0.6.2/setup.py
D shell/ext-py/sasl-0.2.1/LICENSE.txt
D shell/ext-py/sasl-0.2.1/MANIFEST.in
D shell/ext-py/sasl-0.2.1/recython.sh
D shell/ext-py/sasl-0.2.1/sasl/__init__.py
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.cpp
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.h
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.pyx
D shell/ext-py/sasl-0.2.1/setup.py
M shell/ext-py/thrift_sasl-0.4.2/setup.py
M shell/impala-shell
M shell/impala_client.py
A shell/impala_sasl_compat.py
M shell/make_shell_tarball.sh
M shell/packaging/requirements.txt
A tests/util/impala_sasl_compat.py
M tests/util/thrift_util.py
31 files changed, 1,271 insertions(+), 5,093 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17351/8
-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 8:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/17351/8/bin/run-workload.py
File bin/run-workload.py:

http://gerrit.cloudera.org:8080/#/c/17351/8/bin/run-workload.py@223
PS8, Line 223: i
flake8: F401 'puresasl' imported but unused


http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py
File shell/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py@18
PS8, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py@23
PS8, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py@24
PS8, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py@24
PS8, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py
File tests/util/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py@18
PS8, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py@23
PS8, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py@24
PS8, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py@24
PS8, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals



-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 May 2021 07:37:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7107/


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 23:12:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17351

to look at the new patch set (#10).

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................

POC: use puresasl instead of sasl in impala-shell

There are plans to switch to puresasl in Impyla:
https://github.com/attilajeges/thrift_sasl/commit/c95c69a041d89aa7963f4f9d3834d8e347cf05af

This change tries to do the same in Impala to be
able to run Impala's test suite with puresasl.

Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M bin/run-workload.py
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/pure-sasl-0.6.2/CHANGES.rst
A shell/ext-py/pure-sasl-0.6.2/LICENSE
A shell/ext-py/pure-sasl-0.6.2/MANIFEST.in
A shell/ext-py/pure-sasl-0.6.2/PKG-INFO
A shell/ext-py/pure-sasl-0.6.2/README.rst
A shell/ext-py/pure-sasl-0.6.2/puresasl/__init__.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/client.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/mechanisms.py
A shell/ext-py/pure-sasl-0.6.2/setup.cfg
A shell/ext-py/pure-sasl-0.6.2/setup.py
D shell/ext-py/sasl-0.2.1/LICENSE.txt
D shell/ext-py/sasl-0.2.1/MANIFEST.in
D shell/ext-py/sasl-0.2.1/recython.sh
D shell/ext-py/sasl-0.2.1/sasl/__init__.py
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.cpp
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.h
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.pyx
D shell/ext-py/sasl-0.2.1/setup.py
M shell/ext-py/thrift_sasl-0.4.2/setup.py
M shell/impala-shell
M shell/impala_client.py
A shell/impala_sasl_compat.py
M shell/make_shell_tarball.sh
M shell/packaging/requirements.txt
A tests/util/impala_sasl_compat.py
M tests/util/thrift_util.py
31 files changed, 1,271 insertions(+), 5,093 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17351/10
-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8653/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 22:11:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7121/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 May 2021 14:11:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17351

to look at the new patch set (#5).

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................

POC: use puresasl instead of sasl in impala-shell

There are plans to switch to puresasl in Impyla:
https://github.com/attilajeges/thrift_sasl/commit/c95c69a041d89aa7963f4f9d3834d8e347cf05af

This change tries to do the same in Impala to be
able to run Impala's test suite with puresasl.

Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M bin/run-workload.py
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/pure-sasl-0.6.2/CHANGES.rst
A shell/ext-py/pure-sasl-0.6.2/LICENSE
A shell/ext-py/pure-sasl-0.6.2/MANIFEST.in
A shell/ext-py/pure-sasl-0.6.2/PKG-INFO
A shell/ext-py/pure-sasl-0.6.2/README.rst
A shell/ext-py/pure-sasl-0.6.2/puresasl/__init__.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/client.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/mechanisms.py
A shell/ext-py/pure-sasl-0.6.2/setup.cfg
A shell/ext-py/pure-sasl-0.6.2/setup.py
D shell/ext-py/sasl-0.2.1/LICENSE.txt
D shell/ext-py/sasl-0.2.1/MANIFEST.in
D shell/ext-py/sasl-0.2.1/recython.sh
D shell/ext-py/sasl-0.2.1/sasl/__init__.py
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.cpp
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.h
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.pyx
D shell/ext-py/sasl-0.2.1/setup.py
M shell/ext-py/thrift_sasl-0.4.2/setup.py
M shell/impala-shell
M shell/impala_client.py
A shell/impala_sasl_compat.py
M shell/make_shell_tarball.sh
A tests/util/impala_sasl_compat.py
M tests/util/thrift_util.py
30 files changed, 1,270 insertions(+), 5,092 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17351/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 23:09:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8662/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 17:35:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 11: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7173/


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 11
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 May 2021 16:42:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8682/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 May 2021 14:32:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7111/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 14:11:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7107/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 21:49:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8789/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 May 2021 11:09:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7115/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 17:18:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 20:03:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 11:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7173/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 11
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 May 2021 10:49:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 4:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/17351/4/bin/run-workload.py
File bin/run-workload.py:

http://gerrit.cloudera.org:8080/#/c/17351/4/bin/run-workload.py@223
PS4, Line 223: i
flake8: F401 'puresasl' imported but unused


http://gerrit.cloudera.org:8080/#/c/17351/4/shell/impala_sasl_compat.py
File shell/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/4/shell/impala_sasl_compat.py@18
PS4, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/4/shell/impala_sasl_compat.py@23
PS4, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/4/shell/impala_sasl_compat.py@24
PS4, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/4/shell/impala_sasl_compat.py@24
PS4, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/4/tests/util/impala_sasl_compat.py
File tests/util/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/4/tests/util/impala_sasl_compat.py@18
PS4, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/4/tests/util/impala_sasl_compat.py@23
PS4, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/4/tests/util/impala_sasl_compat.py@24
PS4, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/4/tests/util/impala_sasl_compat.py@24
PS4, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals



-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 14:12:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 9: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7138/


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 9
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 May 2021 13:32:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/8658/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 13:11:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8659/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 14:32:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 10:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/17351/10/bin/run-workload.py
File bin/run-workload.py:

http://gerrit.cloudera.org:8080/#/c/17351/10/bin/run-workload.py@223
PS10, Line 223: i
flake8: F401 'puresasl' imported but unused


http://gerrit.cloudera.org:8080/#/c/17351/10/shell/impala_sasl_compat.py
File shell/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/10/shell/impala_sasl_compat.py@18
PS10, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/10/shell/impala_sasl_compat.py@23
PS10, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/10/shell/impala_sasl_compat.py@24
PS10, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/10/shell/impala_sasl_compat.py@24
PS10, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/10/tests/util/impala_sasl_compat.py
File tests/util/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/10/tests/util/impala_sasl_compat.py@18
PS10, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/10/tests/util/impala_sasl_compat.py@23
PS10, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/10/tests/util/impala_sasl_compat.py@24
PS10, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/10/tests/util/impala_sasl_compat.py@24
PS10, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals



-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 May 2021 10:49:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17351

to look at the new patch set (#6).

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................

POC: use puresasl instead of sasl in impala-shell

There are plans to switch to puresasl in Impyla:
https://github.com/attilajeges/thrift_sasl/commit/c95c69a041d89aa7963f4f9d3834d8e347cf05af

This change tries to do the same in Impala to be
able to run Impala's test suite with puresasl.

Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M bin/run-workload.py
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/pure-sasl-0.6.2/CHANGES.rst
A shell/ext-py/pure-sasl-0.6.2/LICENSE
A shell/ext-py/pure-sasl-0.6.2/MANIFEST.in
A shell/ext-py/pure-sasl-0.6.2/PKG-INFO
A shell/ext-py/pure-sasl-0.6.2/README.rst
A shell/ext-py/pure-sasl-0.6.2/puresasl/__init__.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/client.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/mechanisms.py
A shell/ext-py/pure-sasl-0.6.2/setup.cfg
A shell/ext-py/pure-sasl-0.6.2/setup.py
D shell/ext-py/sasl-0.2.1/LICENSE.txt
D shell/ext-py/sasl-0.2.1/MANIFEST.in
D shell/ext-py/sasl-0.2.1/recython.sh
D shell/ext-py/sasl-0.2.1/sasl/__init__.py
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.cpp
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.h
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.pyx
D shell/ext-py/sasl-0.2.1/setup.py
M shell/ext-py/thrift_sasl-0.4.2/setup.py
M shell/impala-shell
M shell/impala_client.py
A shell/impala_sasl_compat.py
M shell/make_shell_tarball.sh
M shell/packaging/requirements.txt
A tests/util/impala_sasl_compat.py
M tests/util/thrift_util.py
31 files changed, 1,271 insertions(+), 5,093 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17351/6
-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17351

to look at the new patch set (#2).

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................

POC: use puresasl instead of sasl in impala-shell

There are plans to switch to puresasl in Impyla:
https://github.com/attilajeges/thrift_sasl/commit/c95c69a041d89aa7963f4f9d3834d8e347cf05af

This change tries to do the same in Impala to be
able to run Impala's test suite with puresasl.

Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M bin/run-workload.py
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/pure-sasl-0.6.2/CHANGES.rst
A shell/ext-py/pure-sasl-0.6.2/LICENSE
A shell/ext-py/pure-sasl-0.6.2/MANIFEST.in
A shell/ext-py/pure-sasl-0.6.2/PKG-INFO
A shell/ext-py/pure-sasl-0.6.2/README.rst
A shell/ext-py/pure-sasl-0.6.2/puresasl/__init__.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/client.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/mechanisms.py
A shell/ext-py/pure-sasl-0.6.2/setup.cfg
A shell/ext-py/pure-sasl-0.6.2/setup.py
D shell/ext-py/sasl-0.2.1/LICENSE.txt
D shell/ext-py/sasl-0.2.1/MANIFEST.in
D shell/ext-py/sasl-0.2.1/recython.sh
D shell/ext-py/sasl-0.2.1/sasl/__init__.py
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.cpp
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.h
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.pyx
D shell/ext-py/sasl-0.2.1/setup.py
M shell/ext-py/thrift_sasl-0.4.2/setup.py
M shell/impala-shell
M shell/impala_client.py
M shell/make_shell_tarball.sh
M tests/util/thrift_util.py
28 files changed, 1,139 insertions(+), 5,092 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17351/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 6:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/17351/6/bin/run-workload.py
File bin/run-workload.py:

http://gerrit.cloudera.org:8080/#/c/17351/6/bin/run-workload.py@223
PS6, Line 223: i
flake8: F401 'puresasl' imported but unused


http://gerrit.cloudera.org:8080/#/c/17351/6/shell/impala_sasl_compat.py
File shell/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/6/shell/impala_sasl_compat.py@18
PS6, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/6/shell/impala_sasl_compat.py@23
PS6, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/6/shell/impala_sasl_compat.py@24
PS6, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/6/shell/impala_sasl_compat.py@24
PS6, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/6/tests/util/impala_sasl_compat.py
File tests/util/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/6/tests/util/impala_sasl_compat.py@18
PS6, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/6/tests/util/impala_sasl_compat.py@23
PS6, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/6/tests/util/impala_sasl_compat.py@24
PS6, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/6/tests/util/impala_sasl_compat.py@24
PS6, Line 24:  
flake8: E251 unexpected spaces around keyword / parameter equals



-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 17:18:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17351/4/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:

http://gerrit.cloudera.org:8080/#/c/17351/4/infra/python/deps/requirements.txt@39
PS4, Line 39: pure-sasl == 0.6.2
Note that there's also a shell/packaging/requirements.txt that refers to sasl==0.2.1



-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 16:11:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 May 2021 19:55:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17351/1/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/17351/1/shell/impala_client.py@26
PS1, Line 26: import puresasl
flake8: F401 'puresasl' imported but unused



-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Apr 2021 21:50:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17351/2/bin/run-workload.py
File bin/run-workload.py:

http://gerrit.cloudera.org:8080/#/c/17351/2/bin/run-workload.py@223
PS2, Line 223: i
flake8: F401 'puresasl' imported but unused


http://gerrit.cloudera.org:8080/#/c/17351/2/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/17351/2/shell/impala_client.py@462
PS2, Line 462: e
flake8: F821 undefined name 'elf'


http://gerrit.cloudera.org:8080/#/c/17351/2/tests/util/thrift_util.py
File tests/util/thrift_util.py:

http://gerrit.cloudera.org:8080/#/c/17351/2/tests/util/thrift_util.py@20
PS2, Line 20: import puresasl
flake8: F401 'puresasl' imported but unused



-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 13:06:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17351

to look at the new patch set (#7).

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................

POC: use puresasl instead of sasl in impala-shell

There are plans to switch to puresasl in Impyla:
https://github.com/attilajeges/thrift_sasl/commit/c95c69a041d89aa7963f4f9d3834d8e347cf05af

This change tries to do the same in Impala to be
able to run Impala's test suite with puresasl.

Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M bin/run-workload.py
M infra/python/deps/requirements.txt
M shell/.gitignore
A shell/ext-py/pure-sasl-0.6.2/CHANGES.rst
A shell/ext-py/pure-sasl-0.6.2/LICENSE
A shell/ext-py/pure-sasl-0.6.2/MANIFEST.in
A shell/ext-py/pure-sasl-0.6.2/PKG-INFO
A shell/ext-py/pure-sasl-0.6.2/README.rst
A shell/ext-py/pure-sasl-0.6.2/puresasl/__init__.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/client.py
A shell/ext-py/pure-sasl-0.6.2/puresasl/mechanisms.py
A shell/ext-py/pure-sasl-0.6.2/setup.cfg
A shell/ext-py/pure-sasl-0.6.2/setup.py
D shell/ext-py/sasl-0.2.1/LICENSE.txt
D shell/ext-py/sasl-0.2.1/MANIFEST.in
D shell/ext-py/sasl-0.2.1/recython.sh
D shell/ext-py/sasl-0.2.1/sasl/__init__.py
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.cpp
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.h
D shell/ext-py/sasl-0.2.1/sasl/saslwrapper.pyx
D shell/ext-py/sasl-0.2.1/setup.py
M shell/ext-py/thrift_sasl-0.4.2/setup.py
M shell/impala-shell
M shell/impala_client.py
A shell/impala_sasl_compat.py
M shell/make_shell_tarball.sh
M shell/packaging/requirements.txt
A tests/util/impala_sasl_compat.py
M tests/util/thrift_util.py
31 files changed, 1,271 insertions(+), 5,093 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17351/7
-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] POC: use puresasl instead of sasl in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7138/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 9
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 May 2021 07:37:39 +0000
Gerrit-HasComments: No