[GitHub] spark pull request: SPARK-11193 - Use Java ConcurrentHashMap inste...

[andrewor14 <gi...@git.apache.org>]

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10203#discussion_r47396435
  
    --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala ---
    @@ -124,8 +125,7 @@ private[kinesis] class KinesisReceiver[T](
       private val seqNumRangesInCurrentBlock = new mutable.ArrayBuffer[SequenceNumberRange]
     
       /** Sequence number ranges of data added to each generated block */
    -  private val blockIdToSeqNumRanges = new mutable.HashMap[StreamBlockId, SequenceNumberRanges]
    -    with mutable.SynchronizedMap[StreamBlockId, SequenceNumberRanges]
    +  private val blockIdToSeqNumRanges = new ConcurrentHashMap[StreamBlockId, SequenceNumberRanges]
    --- End diff --
    
    It's probably always a good idea to use `ConcurrentHashMap` instead of the mixed-in trait. The typesafe people themselves deprecated the trait and said it's unreliable and recommended that users use java's map instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org