You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oltu.apache.org by "Ben Noordhuis (JIRA)" <ji...@apache.org> on 2011/03/10 20:41:59 UTC
[jira] Created: (AMBER-16) HttpServletRequest.getRemoteUser()
should return the name of the security principal, not null.
HttpServletRequest.getRemoteUser() should return the name of the security principal, not null.
----------------------------------------------------------------------------------------------
Key: AMBER-16
URL: https://issues.apache.org/jira/browse/AMBER-16
Project: Amber
Issue Type: Improvement
Components: Server
Reporter: Ben Noordhuis
Priority: Minor
Patchlet for something that tripped me up today. Perhaps it's a wrong assumption but I would expect HttpServletRequest.getRemoteUser() to return something other than null.
Color diff and raw patch:
https://github.com/bnoordhuis/amber/commit/4f921e5
https://github.com/bnoordhuis/amber/commit/4f921e5.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (AMBER-16) HttpServletRequest.getRemoteUser()
should return the name of the security principal, not null.
Posted by "Tommaso Teofili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005557#comment-13005557 ]
Tommaso Teofili commented on AMBER-16:
--------------------------------------
I applied the patch locally, ran mvn install and did tests with a sample app and it seems to me it fixes this issue.
I will make some more tests later today.
> HttpServletRequest.getRemoteUser() should return the name of the security principal, not null.
> ----------------------------------------------------------------------------------------------
>
> Key: AMBER-16
> URL: https://issues.apache.org/jira/browse/AMBER-16
> Project: Amber
> Issue Type: Improvement
> Components: Server
> Reporter: Ben Noordhuis
> Priority: Minor
>
> Patchlet for something that tripped me up today. Perhaps it's a wrong assumption but I would expect HttpServletRequest.getRemoteUser() to return something other than null.
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/compare/AMBER-16
> https://github.com/bnoordhuis/amber/compare/AMBER-16.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (AMBER-16) HttpServletRequest.getRemoteUser()
should return the name of the security principal, not null.
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso closed AMBER-16.
------------------------------
> HttpServletRequest.getRemoteUser() should return the name of the security principal, not null.
> ----------------------------------------------------------------------------------------------
>
> Key: AMBER-16
> URL: https://issues.apache.org/jira/browse/AMBER-16
> Project: Amber
> Issue Type: Improvement
> Components: Server
> Reporter: Ben Noordhuis
> Priority: Minor
> Fix For: 0.22
>
>
> Patchlet for something that tripped me up today. Perhaps it's a wrong assumption but I would expect HttpServletRequest.getRemoteUser() to return something other than null.
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/compare/AMBER-16
> https://github.com/bnoordhuis/amber/compare/AMBER-16.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMBER-16) HttpServletRequest.getRemoteUser()
should return the name of the security principal, not null.
Posted by "Tommaso Teofili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommaso Teofili updated AMBER-16:
---------------------------------
Fix Version/s: 0.22
> HttpServletRequest.getRemoteUser() should return the name of the security principal, not null.
> ----------------------------------------------------------------------------------------------
>
> Key: AMBER-16
> URL: https://issues.apache.org/jira/browse/AMBER-16
> Project: Amber
> Issue Type: Improvement
> Components: Server
> Reporter: Ben Noordhuis
> Priority: Minor
> Fix For: 0.22
>
>
> Patchlet for something that tripped me up today. Perhaps it's a wrong assumption but I would expect HttpServletRequest.getRemoteUser() to return something other than null.
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/compare/AMBER-16
> https://github.com/bnoordhuis/amber/compare/AMBER-16.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (AMBER-16) HttpServletRequest.getRemoteUser()
should return the name of the security principal, not null.
Posted by "Ben Noordhuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Noordhuis updated AMBER-16:
-------------------------------
Description:
Patchlet for something that tripped me up today. Perhaps it's a wrong assumption but I would expect HttpServletRequest.getRemoteUser() to return something other than null.
Color diff and raw patch:
https://github.com/bnoordhuis/amber/compare/AMBER-16
https://github.com/bnoordhuis/amber/compare/AMBER-16.patch
was:
Patchlet for something that tripped me up today. Perhaps it's a wrong assumption but I would expect HttpServletRequest.getRemoteUser() to return something other than null.
Color diff and raw patch:
https://github.com/bnoordhuis/amber/commit/4f921e5
https://github.com/bnoordhuis/amber/commit/4f921e5.patch
> HttpServletRequest.getRemoteUser() should return the name of the security principal, not null.
> ----------------------------------------------------------------------------------------------
>
> Key: AMBER-16
> URL: https://issues.apache.org/jira/browse/AMBER-16
> Project: Amber
> Issue Type: Improvement
> Components: Server
> Reporter: Ben Noordhuis
> Priority: Minor
>
> Patchlet for something that tripped me up today. Perhaps it's a wrong assumption but I would expect HttpServletRequest.getRemoteUser() to return something other than null.
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/compare/AMBER-16
> https://github.com/bnoordhuis/amber/compare/AMBER-16.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (AMBER-16) HttpServletRequest.getRemoteUser()
should return the name of the security principal, not null.
Posted by "Tommaso Teofili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006460#comment-13006460 ]
Tommaso Teofili commented on AMBER-16:
--------------------------------------
Guys I tested it in different scenarios successfully and I think that can be closed
> HttpServletRequest.getRemoteUser() should return the name of the security principal, not null.
> ----------------------------------------------------------------------------------------------
>
> Key: AMBER-16
> URL: https://issues.apache.org/jira/browse/AMBER-16
> Project: Amber
> Issue Type: Improvement
> Components: Server
> Reporter: Ben Noordhuis
> Priority: Minor
>
> Patchlet for something that tripped me up today. Perhaps it's a wrong assumption but I would expect HttpServletRequest.getRemoteUser() to return something other than null.
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/compare/AMBER-16
> https://github.com/bnoordhuis/amber/compare/AMBER-16.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (AMBER-16) HttpServletRequest.getRemoteUser()
should return the name of the security principal, not null.
Posted by "Tommaso Teofili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommaso Teofili resolved AMBER-16.
----------------------------------
Resolution: Fixed
Thanks Ben for your patch :)
> HttpServletRequest.getRemoteUser() should return the name of the security principal, not null.
> ----------------------------------------------------------------------------------------------
>
> Key: AMBER-16
> URL: https://issues.apache.org/jira/browse/AMBER-16
> Project: Amber
> Issue Type: Improvement
> Components: Server
> Reporter: Ben Noordhuis
> Priority: Minor
>
> Patchlet for something that tripped me up today. Perhaps it's a wrong assumption but I would expect HttpServletRequest.getRemoteUser() to return something other than null.
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/compare/AMBER-16
> https://github.com/bnoordhuis/amber/compare/AMBER-16.patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira