You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/31 07:44:55 UTC

[GitHub] [flink-statefun] tzulitai opened a new pull request #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal

tzulitai opened a new pull request #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal
URL: https://github.com/apache/flink-statefun/pull/83
 
 
   We should be using the `apache-release` build profile defined in the Apache Parent POM, with one exclusion: do not run the `source-release-assembly` execution goal.
   
   We have our own scripts to create the source release, which correctly excludes binaries from distribution tarball. That script can be found under `tools/releasing/create_source_release.sh`.
   
   ---
   
   ## Verifying
   
   Build the project using `mvn clean install -Papache-release`.
   Under `project-root/target/`, you should not find any source release packages, only POM files.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink-statefun] tzulitai commented on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal

Posted by GitBox <gi...@apache.org>.
tzulitai commented on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal
URL: https://github.com/apache/flink-statefun/pull/83#issuecomment-606463983
 
 
   @rmetzger correct, Flink defines its own `release` profile, but as far as I can tell, it uses essentially the same plugins used as the `apache-release` profile, minus the `source-release-assembly` execution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink-statefun] tzulitai edited a comment on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal

Posted by GitBox <gi...@apache.org>.
tzulitai edited a comment on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal
URL: https://github.com/apache/flink-statefun/pull/83#issuecomment-606463983
 
 
   @rmetzger correct, Flink defines its own `release` profile, but as far as I can tell, it uses essentially the same plugins used as the `apache-release` profile, minus the `source-release-assembly` execution.
   
   Stateful Functions' build is relatively simpler, so we decided to just reuse the `apache-release` profile.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink-statefun] tzulitai commented on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal

Posted by GitBox <gi...@apache.org>.
tzulitai commented on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal
URL: https://github.com/apache/flink-statefun/pull/83#issuecomment-606459560
 
 
   cc @rmetzger 
   This fixes the problem you found with RC4 of 2.0.0.
   
   This does not require a cancellation of the current ongoing RC, because the artifacts in the new Maven repository for RC4 is still built with the same commit hash.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink-statefun] rmetzger commented on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal

Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal
URL: https://github.com/apache/flink-statefun/pull/83#issuecomment-606462831
 
 
   Thanks a lot for proposing this fix.
   I guess we don't have this problem in apache/flink because we are not using the "apache-release" profile for building the releases there?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink-statefun] tzulitai closed pull request #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal

Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal
URL: https://github.com/apache/flink-statefun/pull/83
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink-statefun] tzulitai commented on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal

Posted by GitBox <gi...@apache.org>.
tzulitai commented on issue #83: [FLINK-16879] [build] Disable the source-release-assembly execution goal
URL: https://github.com/apache/flink-statefun/pull/83#issuecomment-606926780
 
 
   Thanks for the review, merging this ...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services