You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/05/08 09:48:26 UTC

[GitHub] [incubator-ratis] mukul1987 commented on pull request #94: RATIS-932. Avoid usage of ratis-thirdparty-hadoop in ratis-hadoop module.

mukul1987 commented on pull request #94:
URL: https://github.com/apache/incubator-ratis/pull/94#issuecomment-625736006


   Thanks for the review @lokeshj1703 , I did a quick compare of the file ProtobufRpcEngine and also reading from the comments on the file. The file is a copy of ProtobufRpcEngine to use the shaded library. It is safe to remove the reference.
   
   /**
    * Copied from {@link org.apache.hadoop.ipc.ProtobufRpcEngine}
    * and replaced the protobuf classes with the shaded classes.
    */


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org