[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21464: fix: hide time_grain when x_axis value is undefined

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #21464:
URL: https://github.com/apache/superset/pull/21464#discussion_r970657394


##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx:
##########
@@ -332,7 +332,7 @@ const time_grain_sqla: SharedControlConfig<'SelectControl'> = {
 
     const xAxis = controls?.x_axis;
     const xAxisValue = xAxis?.value;
-    if (xAxisValue === undefined || isAdhocColumn(xAxisValue)) {
+    if (isAdhocColumn(xAxisValue)) {

Review Comment:
   Yes, it does. Line 329 returns true when FF is disabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org