You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/04/02 05:54:05 UTC

[GitHub] [incubator-tuweni] atoulme opened a new pull request #204: Add a proxy subprotocol

atoulme opened a new pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204


   ## PR description
   A naive implementation of a protocol allowing the exchange of messages between participants, using the notion of "site".
   
   This subprotocol is added to the devp2p protocol family, and becomes available to coordinate communications between nodes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] atoulme commented on a change in pull request #204: Add a proxy subprotocol

Posted by GitBox <gi...@apache.org>.
atoulme commented on a change in pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204#discussion_r606312397



##########
File path: devp2p-proxy/src/main/kotlin/org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tuweni.devp2p.proxy
+
+import org.apache.tuweni.rlpx.RLPxService
+import org.apache.tuweni.rlpx.wire.SubProtocol
+import org.apache.tuweni.rlpx.wire.SubProtocolClient
+import org.apache.tuweni.rlpx.wire.SubProtocolIdentifier
+
+class ProxySubprotocol() : SubProtocol {
+
+  companion object {
+    val ID = SubProtocolIdentifier.of("proxy", 1)

Review comment:
       We can certainly abide to tradition - is pxy ok?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #204: Add a proxy subprotocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204#issuecomment-812338938


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=h1) Report
   > Merging [#204](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=desc) (ff4c552) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/e51155bf94059bc33fe3f051bf81f51e304ac510?el=desc) (e51155b) will **decrease** coverage by `0.25%`.
   > The diff coverage is `72.07%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/204/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #204      +/-   ##
   ============================================
   - Coverage     64.57%   64.32%   -0.26%     
   - Complexity     4172     4209      +37     
   ============================================
     Files           385      394       +9     
     Lines         20186    20530     +344     
     Branches       2622     2668      +46     
   ============================================
   + Hits          13035    13205     +170     
   - Misses         5695     5849     +154     
   - Partials       1456     1476      +20     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | integration | `46.99% <72.07%> (+0.45%)` | `0.00 <22.00> (ø)` | |
   | unit | `59.47% <56.75%> (-0.27%)` | `0.00 <22.00> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...tlin/org/apache/tuweni/devp2p/proxy/ProxyClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlDbGllbnQua3Q=) | `61.90% <61.90%> (ø)` | `4.00 <4.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/proxy/ProxyHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlIYW5kbGVyLmt0) | `71.25% <71.25%> (ø)` | `8.00 <8.00> (?)` | |
   | [.../apache/tuweni/devp2p/proxy/ProxyPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlQZWVyUmVwb3NpdG9yeS5rdA==) | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlTdWJwcm90b2NvbC5rdA==) | `100.00% <100.00%> (ø)` | `7.00 <7.00> (?)` | |
   | [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
   | [...a/org/apache/tuweni/crypto/sodium/KeyExchange.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9LZXlFeGNoYW5nZS5qYXZh) | `36.77% <0.00%> (-2.70%)` | `2.00% <0.00%> (ø%)` | |
   | [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `78.72% <0.00%> (-2.13%)` | `0.00% <0.00%> (ø%)` | |
   | [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `50.00% <0.00%> (-1.93%)` | `4.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/tuweni/crypto/sodium/AES256GCM.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9BRVMyNTZHQ00uamF2YQ==) | `45.20% <0.00%> (-1.20%)` | `22.00% <0.00%> (-2.00%)` | |
   | [...main/java/org/apache/tuweni/crypto/sodium/Box.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9Cb3guamF2YQ==) | `53.17% <0.00%> (-0.87%)` | `24.00% <0.00%> (-2.00%)` | |
   | ... and [11 more](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=footer). Last update [e51155b...ff4c552](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #204: Add a proxy subprotocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204#issuecomment-812338938


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=h1) Report
   > Merging [#204](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=desc) (b161bd2) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/e51155bf94059bc33fe3f051bf81f51e304ac510?el=desc) (e51155b) will **decrease** coverage by `5.12%`.
   > The diff coverage is `56.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/204/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #204      +/-   ##
   ============================================
   - Coverage     64.57%   59.44%   -5.13%     
   + Complexity     4172     3897     -275     
   ============================================
     Files           385      369      -16     
     Lines         20186    20149      -37     
     Branches       2622     2661      +39     
   ============================================
   - Hits          13035    11978    -1057     
   - Misses         5695     6813    +1118     
   + Partials       1456     1358      -98     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | integration | `?` | `?` | |
   | unit | `59.44% <56.75%> (-0.30%)` | `0.00 <14.00> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlTdWJwcm90b2NvbC5rdA==) | `14.28% <14.28%> (ø)` | `1.00 <1.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/proxy/ProxyHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlIYW5kbGVyLmt0) | `57.50% <57.50%> (ø)` | `6.00 <6.00> (?)` | |
   | [...tlin/org/apache/tuweni/devp2p/proxy/ProxyClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlDbGllbnQua3Q=) | `61.90% <61.90%> (ø)` | `4.00 <4.00> (?)` | |
   | [.../apache/tuweni/devp2p/proxy/ProxyPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlQZWVyUmVwb3NpdG9yeS5rdA==) | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [87 more](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=footer). Last update [e51155b...b161bd2](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] atoulme merged pull request #204: Add a proxy subprotocol

Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] rojotek commented on a change in pull request #204: Add a proxy subprotocol

Posted by GitBox <gi...@apache.org>.
rojotek commented on a change in pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204#discussion_r606897014



##########
File path: devp2p-proxy/src/main/kotlin/org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tuweni.devp2p.proxy
+
+import org.apache.tuweni.rlpx.RLPxService
+import org.apache.tuweni.rlpx.wire.SubProtocol
+import org.apache.tuweni.rlpx.wire.SubProtocolClient
+import org.apache.tuweni.rlpx.wire.SubProtocolIdentifier
+
+class ProxySubprotocol() : SubProtocol {
+
+  companion object {
+    val ID = SubProtocolIdentifier.of("proxy", 1)

Review comment:
       pxy works.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #204: Add a proxy subprotocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204#issuecomment-812338938


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=h1) Report
   > Merging [#204](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=desc) (b161bd2) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/e51155bf94059bc33fe3f051bf81f51e304ac510?el=desc) (e51155b) will **decrease** coverage by `5.12%`.
   > The diff coverage is `56.75%`.
   
   > :exclamation: Current head b161bd2 differs from pull request most recent head ff4c552. Consider uploading reports for the commit ff4c552 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/204/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #204      +/-   ##
   ============================================
   - Coverage     64.57%   59.44%   -5.13%     
   + Complexity     4172     3897     -275     
   ============================================
     Files           385      369      -16     
     Lines         20186    20149      -37     
     Branches       2622     2661      +39     
   ============================================
   - Hits          13035    11978    -1057     
   - Misses         5695     6813    +1118     
   + Partials       1456     1358      -98     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | integration | `?` | `?` | |
   | unit | `59.44% <56.75%> (-0.30%)` | `0.00 <14.00> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlTdWJwcm90b2NvbC5rdA==) | `14.28% <14.28%> (ø)` | `1.00 <1.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/proxy/ProxyHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlIYW5kbGVyLmt0) | `57.50% <57.50%> (ø)` | `6.00 <6.00> (?)` | |
   | [...tlin/org/apache/tuweni/devp2p/proxy/ProxyClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlDbGllbnQua3Q=) | `61.90% <61.90%> (ø)` | `4.00 <4.00> (?)` | |
   | [.../apache/tuweni/devp2p/proxy/ProxyPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlQZWVyUmVwb3NpdG9yeS5rdA==) | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [87 more](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=footer). Last update [e51155b...ff4c552](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] rojotek commented on pull request #204: Add a proxy subprotocol

Posted by GitBox <gi...@apache.org>.
rojotek commented on pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204#issuecomment-813155843


   with a change to the subprotocol to use a 3 char code lgtm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] rojotek commented on a change in pull request #204: Add a proxy subprotocol

Posted by GitBox <gi...@apache.org>.
rojotek commented on a change in pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204#discussion_r606102697



##########
File path: devp2p-proxy/src/main/kotlin/org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tuweni.devp2p.proxy
+
+import org.apache.tuweni.rlpx.RLPxService
+import org.apache.tuweni.rlpx.wire.SubProtocol
+import org.apache.tuweni.rlpx.wire.SubProtocolClient
+import org.apache.tuweni.rlpx.wire.SubProtocolIdentifier
+
+class ProxySubprotocol() : SubProtocol {
+
+  companion object {
+    val ID = SubProtocolIdentifier.of("proxy", 1)

Review comment:
       I have in my head that sub protocol identifiers are meant to be 3 chars long, but this isn't really enforced anywhere.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org

[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #204: Add a proxy subprotocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #204:
URL: https://github.com/apache/incubator-tuweni/pull/204#issuecomment-812338938


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=h1) Report
   > Merging [#204](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=desc) (ff4c552) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/e51155bf94059bc33fe3f051bf81f51e304ac510?el=desc) (e51155b) will **decrease** coverage by `5.09%`.
   > The diff coverage is `56.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/204/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #204      +/-   ##
   ============================================
   - Coverage     64.57%   59.47%   -5.10%     
   + Complexity     4172     3897     -275     
   ============================================
     Files           385      369      -16     
     Lines         20186    20149      -37     
     Branches       2622     2661      +39     
   ============================================
   - Hits          13035    11984    -1051     
   - Misses         5695     6811    +1116     
   + Partials       1456     1354     -102     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | integration | `?` | `?` | |
   | unit | `59.47% <56.75%> (-0.27%)` | `0.00 <14.00> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlTdWJwcm90b2NvbC5rdA==) | `14.28% <14.28%> (ø)` | `1.00 <1.00> (?)` | |
   | [...lin/org/apache/tuweni/devp2p/proxy/ProxyHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlIYW5kbGVyLmt0) | `57.50% <57.50%> (ø)` | `6.00 <6.00> (?)` | |
   | [...tlin/org/apache/tuweni/devp2p/proxy/ProxyClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlDbGllbnQua3Q=) | `61.90% <61.90%> (ø)` | `4.00 <4.00> (?)` | |
   | [.../apache/tuweni/devp2p/proxy/ProxyPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlQZWVyUmVwb3NpdG9yeS5rdA==) | `100.00% <100.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [87 more](https://codecov.io/gh/apache/incubator-tuweni/pull/204/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=footer). Last update [e51155b...ff4c552](https://codecov.io/gh/apache/incubator-tuweni/pull/204?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org