You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by plasma <pl...@pchome.com.tw> on 2004/03/03 01:01:26 UTC
Duplicate directory in books/
Hi all,
I was checking svnbook in release tarball, and found there is a
'doc/book/book/images/images' directory. The files in there look
as the same as in 'doc/book/book/images'. Is this intended?
plasma
==========================================================
PChome���~~���֤ѤѦ� \*^o^*//
http://love.pchome.com.tw/
==========================================================
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix Duplicate directory in books/
Posted by Tobias Ringström <to...@ringstrom.mine.nu>.
Ben Reser wrote:
> On Wed, Mar 03, 2004 at 09:55:08AM +0100, Tobias_Ringström wrote:
>
>>This was perhaps what the original author inteded, but it's strange.
>>The images directory is already present in the exported tree, so the
>>copy seems redundant. But there seems to be a potential problem here.
>>The book version in the tree may not be the same as the prebuilt one
>>from svnbook.red-bean.com, so the prebuilt book.html may not match the
>>images directory in the exported tree. If we were to copy the images
>>directory from red-bean, that images directory may not match the book
>>source in the exported tree.
>
> Per the release procedures the book guys are supposed to keep the
> svnbook.red-bean.com up to date. So the release manager should ignore
> this. As you pointed out copying the images makes no sense. Attached
> is a patch that removes that.
+1
/Tobias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] Fix Duplicate directory in books/
Posted by Ben Reser <be...@reser.org>.
On Wed, Mar 03, 2004 at 09:55:08AM +0100, Tobias_Ringström wrote:
> This was perhaps what the original author inteded, but it's strange.
> The images directory is already present in the exported tree, so the
> copy seems redundant. But there seems to be a potential problem here.
> The book version in the tree may not be the same as the prebuilt one
> from svnbook.red-bean.com, so the prebuilt book.html may not match the
> images directory in the exported tree. If we were to copy the images
> directory from red-bean, that images directory may not match the book
> source in the exported tree.
Per the release procedures the book guys are supposed to keep the
svnbook.red-bean.com up to date. So the release manager should ignore
this. As you pointed out copying the images makes no sense. Attached
is a patch that removes that.
[[[
Fix duplicate images directory in tarball.
* dist.sh
Do not copy doc/book/book/images into the sandbox when building the
tarball. It should already be there from the export.
]]]
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
Re: [PATCH] Fix Duplicate directory in books/
Posted by David Summers <da...@summersoft.fay.ar.us>.
On Wed, 3 Mar 2004, Brian W. Fitzpatrick wrote:
> On Mar 3, 2004, at 3:01 AM, Justin Erenkrantz wrote:
>
> > --On Wednesday, March 3, 2004 9:55 AM +0100 Tobias Ringström
> > <to...@ringstrom.mine.nu> wrote:
> >
> >> Wouldn't it be better to have the release manager build the book from
> >> the
> >> source. How hard can it be? (And if it is that hard, maybe we can
> >> make it
> >> easier?)
> >
> > ISTR Jostein mentioning that the pre-requisites on building the book
> > are insanely hard to satisfy.
>
> This is true, and the reason that we just grab the book from
> svnbook.red-bean.com
>
I just wanted to note that I "build the book" every time I build an RPM.
It has been part of the RPM build now for about a year, I think.
--
David Wayne Summers "Linux: Because reboots are for hardware upgrades!"
david@summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint = C0 E0 4F 50 DD A9 B6 2B 60 A1 31 7E D2 28 6D A8
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix Duplicate directory in books/
Posted by "Brian W. Fitzpatrick" <fi...@red-bean.com>.
On Mar 3, 2004, at 3:01 AM, Justin Erenkrantz wrote:
> --On Wednesday, March 3, 2004 9:55 AM +0100 Tobias Ringström
> <to...@ringstrom.mine.nu> wrote:
>
>> Wouldn't it be better to have the release manager build the book from
>> the
>> source. How hard can it be? (And if it is that hard, maybe we can
>> make it
>> easier?)
>
> ISTR Jostein mentioning that the pre-requisites on building the book
> are insanely hard to satisfy.
This is true, and the reason that we just grab the book from
svnbook.red-bean.com
-Fitz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix Duplicate directory in books/
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Wednesday, March 3, 2004 9:55 AM +0100 Tobias Ringström
<to...@ringstrom.mine.nu> wrote:
> Wouldn't it be better to have the release manager build the book from the
> source. How hard can it be? (And if it is that hard, maybe we can make it
> easier?)
ISTR Jostein mentioning that the pre-requisites on building the book are
insanely hard to satisfy. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix Duplicate directory in books/
Posted by Tobias Ringström <to...@ringstrom.mine.nu>.
Ben Reser wrote:
> On Wed, Mar 03, 2004 at 09:01:26AM +0800, plasma wrote:
>
>>I was checking svnbook in release tarball, and found there is a
>>'doc/book/book/images/images' directory. The files in there look
>>as the same as in 'doc/book/book/images'. Is this intended?
>
> [[[
> * dist.sh
>
> Fix error in copying images that results in two images directories.
> ]]]
This was perhaps what the original author inteded, but it's strange.
The images directory is already present in the exported tree, so the
copy seems redundant. But there seems to be a potential problem here.
The book version in the tree may not be the same as the prebuilt one
from svnbook.red-bean.com, so the prebuilt book.html may not match the
images directory in the exported tree. If we were to copy the images
directory from red-bean, that images directory may not match the book
source in the exported tree.
Wouldn't it be better to have the release manager build the book from
the source. How hard can it be? (And if it is that hard, maybe we can
make it easier?)
/Tobias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] Fix Duplicate directory in books/
Posted by Ben Reser <be...@reser.org>.
On Wed, Mar 03, 2004 at 09:01:26AM +0800, plasma wrote:
> I was checking svnbook in release tarball, and found there is a
> 'doc/book/book/images/images' directory. The files in there look
> as the same as in 'doc/book/book/images'. Is this intended?
[[[
* dist.sh
Fix error in copying images that results in two images directories.
]]]
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
Re: Duplicate directory in books/
Posted by Ben Reser <be...@reser.org>.
On Wed, Mar 03, 2004 at 09:01:26AM +0800, plasma wrote:
> I was checking svnbook in release tarball, and found there is a
> 'doc/book/book/images/images' directory. The files in there look
> as the same as in 'doc/book/book/images'. Is this intended?
Bug in dist.sh. Patch forthcoming.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org