You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/21 09:08:01 UTC

[GitHub] [pulsar] gaozhangmin opened a new pull request, #19015: [improve][admin] Improve partitioned-topic condition evaluation

gaozhangmin opened a new pull request, #19015:
URL: https://github.com/apache/pulsar/pull/19015

   ### Motivation
   Partition-topic condition change from `!topicName.isPartitioned() && partitionMetadata.partitions > 0` to ` partitionMetadata.partitions > 0`
   
   ### Modifications
   
   Partition-topic condition change from `!topicName.isPartitioned() && partitionMetadata.partitions > 0` to ` partitionMetadata.partitions > 0`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   https://github.com/gaozhangmin/pulsar/pull/6
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on a diff in pull request #19015: [improve][admin] Improve partitioned-topic condition evaluation

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #19015:
URL: https://github.com/apache/pulsar/pull/19015#discussion_r1091886551


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -2608,80 +2608,87 @@ protected void internalGetSubscriptionProperties(AsyncResponse asyncResponse, St
     protected void internalResetCursorOnPosition(AsyncResponse asyncResponse, String subName, boolean authoritative,
             MessageIdImpl messageId, boolean isExcluded, int batchIndex) {
         CompletableFuture<Void> ret;
-        if (topicName.isGlobal()) {
-            ret = validateGlobalNamespaceOwnershipAsync(namespaceName);
+        // If the topic name is a partition name, no need to get partition topic metadata again
+        if (!topicName.isPartitioned()) {
+            ret = getPartitionedTopicMetadataAsync(topicName, authoritative, false)
+                    .thenCompose(topicMetadata -> {
+                        if (topicMetadata.partitions > 0) {
+                            log.warn("[{}] Not supported operation on partitioned-topic {} {}",
+                                    clientAppId(), topicName, subName);
+                            asyncResponse.resume(new RestException(Status.METHOD_NOT_ALLOWED,
+                                    "Reset-cursor at position is not allowed for partitioned-topic"));
+                        }
+                        return CompletableFuture.completedFuture(null);
+                    });
         } else {
             ret = CompletableFuture.completedFuture(null);
         }
-        ret.thenAccept(__ -> {
+
+        CompletableFuture<Void> future;
+        if (topicName.isGlobal()) {
+            future = ret.thenCompose(__ -> validateGlobalNamespaceOwnershipAsync(namespaceName));
+        } else {
+            future = CompletableFuture.completedFuture(null);
+        }
+        future.thenAccept(__ -> {
             log.info("[{}][{}] received reset cursor on subscription {} to position {}", clientAppId(), topicName,
                     subName, messageId);
-            // If the topic name is a partition name, no need to get partition topic metadata again
-            if (!topicName.isPartitioned()
-                    && getPartitionedTopicMetadata(topicName, authoritative, false).partitions > 0) {

Review Comment:
   This fixes an issue where Zookeeper session dies because the EventThread is blocked
   Stack trace
   ```
   "main-EventThread" #17 daemon prio=5 os_prio=0 cpu=1788.73ms elapsed=5176.10s tid=0x00007fa97a581000 nid=0x54 waiting on condition  [0x00007fa8ffbfb000]
      java.lang.Thread.State: WAITING (parking)
   	at jdk.internal.misc.Unsafe.park(java.base@11.0.16/Native Method)
   	- parking to wait for  <0x00000007dbaff838> (a java.util.concurrent.CompletableFuture$Signaller)
   	at java.util.concurrent.locks.LockSupport.park(java.base@11.0.16/LockSupport.java:194)
   	at java.util.concurrent.CompletableFuture$Signaller.block(java.base@11.0.16/CompletableFuture.java:1796)
   	at java.util.concurrent.ForkJoinPool.managedBlock(java.base@11.0.16/ForkJoinPool.java:3128)
   	at java.util.concurrent.CompletableFuture.waitingGet(java.base@11.0.16/CompletableFuture.java:1823)
   	at java.util.concurrent.CompletableFuture.get(java.base@11.0.16/CompletableFuture.java:1998)
   	at org.apache.pulsar.broker.admin.AdminResource.fetchPartitionedTopicMetadata(AdminResource.java:492)
   	at org.apache.pulsar.broker.admin.AdminResource.getPartitionedTopicMetadata(AdminResource.java:480)
   	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalResetCursorOnPosition$212(PersistentTopicsBase.java:2595)
   	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase$$Lambda$1475/0x0000000840b46840.accept(Unknown Source)
   	at java.util.concurrent.CompletableFuture$UniAccept.tryFire(java.base@11.0.16/CompletableFuture.java:714)
   	at java.util.concurrent.CompletableFuture.postComplete(java.base@11.0.16/CompletableFuture.java:506)
   	at java.util.concurrent.CompletableFuture.complete(java.base@11.0.16/CompletableFuture.java:2073)
   	at org.apache.pulsar.broker.web.PulsarWebResource.lambda$checkLocalOrGetPeerReplicationCluster$21(PulsarWebResource.java:859)
   	at org.apache.pulsar.broker.web.PulsarWebResource$$Lambda$1135/0x000000084096fc40.accept(Unknown Source)
   	at java.util.concurrent.CompletableFuture$UniAccept.tryFire(java.base@11.0.16/CompletableFuture.java:714)
   	at java.util.concurrent.CompletableFuture.postComplete(java.base@11.0.16/CompletableFuture.java:506)
   	at java.util.concurrent.CompletableFuture.complete(java.base@11.0.16/CompletableFuture.java:2073)
   	at org.apache.pulsar.metadata.impl.ZKMetadataStore.handleGetResult(ZKMetadataStore.java:244)
   	at org.apache.pulsar.metadata.impl.ZKMetadataStore.lambda$batchOperation$7(ZKMetadataStore.java:188)
   	at org.apache.pulsar.metadata.impl.ZKMetadataStore$$Lambda$177/0x00000008402da040.processResult(Unknown Source)
   	at org.apache.pulsar.metadata.impl.PulsarZooKeeperClient$3$1.processResult(PulsarZooKeeperClient.java:490)
   	at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:712)
   	at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:553)
      Locked ownable synchronizers:
   	- None
   ```
   (line numbers for https://github.com/datastax/pulsar/tree/ls210_2.3)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] gaozhangmin merged pull request #19015: [improve][admin] Improve partitioned-topic condition evaluation

Posted by "gaozhangmin (via GitHub)" <gi...@apache.org>.
gaozhangmin merged PR #19015:
URL: https://github.com/apache/pulsar/pull/19015


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] AnonHxy commented on a diff in pull request #19015: [improve][admin] Improve partitioned-topic condition evaluation

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on code in PR #19015:
URL: https://github.com/apache/pulsar/pull/19015#discussion_r1061377862


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -3716,6 +3720,15 @@ protected CompletableFuture<MessageId> internalTerminateAsync(boolean authoritat
     }
 
     protected void internalTerminatePartitionedTopic(AsyncResponse asyncResponse, boolean authoritative) {
+        // If the topic name is a partition name, no need to get partition topic metadata again

Review Comment:
   This comments looks not correct here,  It's just not support partitioned topicName. How about remove it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19015: [improve][admin] Improve partitioned-topic condition evaluation

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #19015:
URL: https://github.com/apache/pulsar/pull/19015#issuecomment-1432692548

   Since this happens to fix a critical issue (check comment https://github.com/apache/pulsar/pull/19015#discussion_r1091886551), this is needed for branch-2.11 too. 
   The PR doesn't apply to branch-2.10 so I'll make a separate PR targeting the specific issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on a diff in pull request #19015: [improve][admin] Improve partitioned-topic condition evaluation

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #19015:
URL: https://github.com/apache/pulsar/pull/19015#discussion_r1091886551


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -2608,80 +2608,87 @@ protected void internalGetSubscriptionProperties(AsyncResponse asyncResponse, St
     protected void internalResetCursorOnPosition(AsyncResponse asyncResponse, String subName, boolean authoritative,
             MessageIdImpl messageId, boolean isExcluded, int batchIndex) {
         CompletableFuture<Void> ret;
-        if (topicName.isGlobal()) {
-            ret = validateGlobalNamespaceOwnershipAsync(namespaceName);
+        // If the topic name is a partition name, no need to get partition topic metadata again
+        if (!topicName.isPartitioned()) {
+            ret = getPartitionedTopicMetadataAsync(topicName, authoritative, false)
+                    .thenCompose(topicMetadata -> {
+                        if (topicMetadata.partitions > 0) {
+                            log.warn("[{}] Not supported operation on partitioned-topic {} {}",
+                                    clientAppId(), topicName, subName);
+                            asyncResponse.resume(new RestException(Status.METHOD_NOT_ALLOWED,
+                                    "Reset-cursor at position is not allowed for partitioned-topic"));
+                        }
+                        return CompletableFuture.completedFuture(null);
+                    });
         } else {
             ret = CompletableFuture.completedFuture(null);
         }
-        ret.thenAccept(__ -> {
+
+        CompletableFuture<Void> future;
+        if (topicName.isGlobal()) {
+            future = ret.thenCompose(__ -> validateGlobalNamespaceOwnershipAsync(namespaceName));
+        } else {
+            future = CompletableFuture.completedFuture(null);
+        }
+        future.thenAccept(__ -> {
             log.info("[{}][{}] received reset cursor on subscription {} to position {}", clientAppId(), topicName,
                     subName, messageId);
-            // If the topic name is a partition name, no need to get partition topic metadata again
-            if (!topicName.isPartitioned()
-                    && getPartitionedTopicMetadata(topicName, authoritative, false).partitions > 0) {

Review Comment:
   This fixes an issue where Zookeeper session dies because the EventThread is blocked
   Stack trace
   ```
   "main-EventThread" #17 daemon prio=5 os_prio=0 cpu=1788.73ms elapsed=5176.10s tid=0x00007fa97a581000 nid=0x54 waiting on condition  [0x00007fa8ffbfb000]
      java.lang.Thread.State: WAITING (parking)
   	at jdk.internal.misc.Unsafe.park(java.base@11.0.16/Native Method)
   	- parking to wait for  <0x00000007dbaff838> (a java.util.concurrent.CompletableFuture$Signaller)
   	at java.util.concurrent.locks.LockSupport.park(java.base@11.0.16/LockSupport.java:194)
   	at java.util.concurrent.CompletableFuture$Signaller.block(java.base@11.0.16/CompletableFuture.java:1796)
   	at java.util.concurrent.ForkJoinPool.managedBlock(java.base@11.0.16/ForkJoinPool.java:3128)
   	at java.util.concurrent.CompletableFuture.waitingGet(java.base@11.0.16/CompletableFuture.java:1823)
   	at java.util.concurrent.CompletableFuture.get(java.base@11.0.16/CompletableFuture.java:1998)
   	at org.apache.pulsar.broker.admin.AdminResource.fetchPartitionedTopicMetadata(AdminResource.java:492)
   	at org.apache.pulsar.broker.admin.AdminResource.getPartitionedTopicMetadata(AdminResource.java:480)
   	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalResetCursorOnPosition$212(PersistentTopicsBase.java:2595)
   	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase$$Lambda$1475/0x0000000840b46840.accept(Unknown Source)
   	at java.util.concurrent.CompletableFuture$UniAccept.tryFire(java.base@11.0.16/CompletableFuture.java:714)
   	at java.util.concurrent.CompletableFuture.postComplete(java.base@11.0.16/CompletableFuture.java:506)
   	at java.util.concurrent.CompletableFuture.complete(java.base@11.0.16/CompletableFuture.java:2073)
   	at org.apache.pulsar.broker.web.PulsarWebResource.lambda$checkLocalOrGetPeerReplicationCluster$21(PulsarWebResource.java:859)
   	at org.apache.pulsar.broker.web.PulsarWebResource$$Lambda$1135/0x000000084096fc40.accept(Unknown Source)
   	at java.util.concurrent.CompletableFuture$UniAccept.tryFire(java.base@11.0.16/CompletableFuture.java:714)
   	at java.util.concurrent.CompletableFuture.postComplete(java.base@11.0.16/CompletableFuture.java:506)
   	at java.util.concurrent.CompletableFuture.complete(java.base@11.0.16/CompletableFuture.java:2073)
   	at org.apache.pulsar.metadata.impl.ZKMetadataStore.handleGetResult(ZKMetadataStore.java:244)
   	at org.apache.pulsar.metadata.impl.ZKMetadataStore.lambda$batchOperation$7(ZKMetadataStore.java:188)
   	at org.apache.pulsar.metadata.impl.ZKMetadataStore$$Lambda$177/0x00000008402da040.processResult(Unknown Source)
   	at org.apache.pulsar.metadata.impl.PulsarZooKeeperClient$3$1.processResult(PulsarZooKeeperClient.java:490)
   	at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:712)
   	at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:553)
      Locked ownable synchronizers:
   	- None
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] congbobo184 commented on pull request #19015: [improve][admin] Improve partitioned-topic condition evaluation

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on PR #19015:
URL: https://github.com/apache/pulsar/pull/19015#issuecomment-1361283546

   > We can avoid getting the partitioned topic metadata if the given topic name is a topic partition.
   
   If it is a partition topic, we don't need to get topic metadata. `internalExpireMessagesNonPartitionedTopicByPosition` directly, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19015: [improve][admin] Improve partitioned-topic condition evaluation

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on code in PR #19015:
URL: https://github.com/apache/pulsar/pull/19015#discussion_r1054367134


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -3204,7 +3204,7 @@ protected void internalGetBacklogSizeByMessageId(AsyncResponse asyncResponse,
         future.thenAccept(__ -> {
             getPartitionedTopicMetadataAsync(topicName, authoritative, false)
                     .thenAccept(partitionMetadata -> {
-                        if (!topicName.isPartitioned() && partitionMetadata.partitions > 0) {
+                        if (partitionMetadata.partitions > 0) {

Review Comment:
   if the `topicName.isPartitioned()`, we don't need to `getPartitionedTopicMetadataAsync`, `managedLedger.getEstimatedBacklogSize(pos)` directly, right? 
   
   
   The same as below change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codecov-commenter commented on pull request #19015: [improve][admin] Improve partitioned-topic condition evaluation

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19015:
URL: https://github.com/apache/pulsar/pull/19015#issuecomment-1361699925

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19015?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19015](https://codecov.io/gh/apache/pulsar/pull/19015?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (adb35fc) into [master](https://codecov.io/gh/apache/pulsar/commit/08591d9da87579705f8ee950d745718a92bdd15e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08591d9) will **decrease** coverage by `7.38%`.
   > The diff coverage is `49.54%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/19015/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/19015?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19015      +/-   ##
   ============================================
   - Coverage     49.85%   42.47%   -7.39%     
   - Complexity     8658    10233    +1575     
   ============================================
     Files           500      769     +269     
     Lines         54930    74127   +19197     
     Branches       5867     7976    +2109     
   ============================================
   + Hits          27386    31484    +4098     
   - Misses        24464    38949   +14485     
   - Partials       3080     3694     +614     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `42.47% <49.54%> (-7.39%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19015?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pulsar/broker/admin/impl/PersistentTopicsBase.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL1BlcnNpc3RlbnRUb3BpY3NCYXNlLmphdmE=) | `58.28% <49.54%> (-0.44%)` | :arrow_down: |
   | [...pache/pulsar/client/impl/CompactionReaderImpl.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0NvbXBhY3Rpb25SZWFkZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
   | [...g/apache/pulsar/client/impl/RawBatchConverter.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Jhd0JhdGNoQ29udmVydGVyLmphdmE=) | `3.12% <0.00%> (-89.07%)` | :arrow_down: |
   | [...g/apache/pulsar/broker/service/StreamingStats.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1N0cmVhbWluZ1N0YXRzLmphdmE=) | `0.00% <0.00%> (-83.79%)` | :arrow_down: |
   | [.../pulsar/compaction/StrategicTwoPhaseCompactor.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbXBhY3Rpb24vU3RyYXRlZ2ljVHdvUGhhc2VDb21wYWN0b3IuamF2YQ==) | `0.00% <0.00%> (-76.20%)` | :arrow_down: |
   | [...sar/broker/stats/metrics/ManagedLedgerMetrics.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9tZXRyaWNzL01hbmFnZWRMZWRnZXJNZXRyaWNzLmphdmE=) | `23.88% <0.00%> (-76.12%)` | :arrow_down: |
   | [...lsar/client/impl/RawBatchMessageContainerImpl.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Jhd0JhdGNoTWVzc2FnZUNvbnRhaW5lckltcGwuamF2YQ==) | `0.00% <0.00%> (-73.14%)` | :arrow_down: |
   | [.../pulsar/broker/service/SharedConsumerAssignor.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1NoYXJlZENvbnN1bWVyQXNzaWdub3IuamF2YQ==) | `3.70% <0.00%> (-64.82%)` | :arrow_down: |
   | [...lsar/broker/service/StickyKeyConsumerSelector.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1N0aWNreUtleUNvbnN1bWVyU2VsZWN0b3IuamF2YQ==) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [...rvice/schema/KeyValueSchemaCompatibilityCheck.java](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9LZXlWYWx1ZVNjaGVtYUNvbXBhdGliaWxpdHlDaGVjay5qYXZh) | `21.62% <0.00%> (-45.95%)` | :arrow_down: |
   | ... and [355 more](https://codecov.io/gh/apache/pulsar/pull/19015/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] AnonHxy commented on pull request #19015: [improve][admin] Improve partitioned-topic condition evaluation

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #19015:
URL: https://github.com/apache/pulsar/pull/19015#issuecomment-1370796182

   LGTM with minor comments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org