[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28848: [SPARK-32003][CORE] Unregister outputs for executor on fetch failure …

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #28848:
URL: https://github.com/apache/spark/pull/28848#discussion_r443083211



##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1939,24 +1941,24 @@ private[spark] class DAGScheduler(
       hostToUnregisterOutputs: Option[String],
       maybeEpoch: Option[Long] = None): Unit = {
     val currentEpoch = maybeEpoch.getOrElse(mapOutputTracker.getEpoch)
+    logDebug(s"Considering removal of executor $execId; " +
+      s"fileLost: $fileLost, currentEpoch: $currentEpoch")
     if (!failedEpoch.contains(execId) || failedEpoch(execId) < currentEpoch) {
       failedEpoch(execId) = currentEpoch
-      logInfo("Executor lost: %s (epoch %d)".format(execId, currentEpoch))
+      logInfo(s"Executor lost: $execId (epoch $currentEpoch)")

Review comment:
       If you don't mind, can we avoid a style change like this in order to focus the feature?
   ```
   - logInfo("Executor lost: %s (epoch %d)".format(execId, currentEpoch))
   + logInfo(s"Executor lost: $execId (epoch $currentEpoch)")
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org