You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/18 03:25:43 UTC
[GitHub] [pulsar-test-infra] michaeljmarshall opened a new issue, #73: [pulsarbot] Bot should not comment on closed/merged PRs
michaeljmarshall opened a new issue, #73:
URL: https://github.com/apache/pulsar-test-infra/issues/73
I noticed the Pulsar Bot comment on old PRs that have either been merged or closed. I don't think we should have the bot updating those old PRs since it just creates unnecessary notifications for contributors.
I'm not able to help add this feature. This issue is just meant to start a conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] tisonkun commented on issue #73: [pulsarbot] Bot should not comment on closed/merged PRs
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #73:
URL: https://github.com/apache/pulsar-test-infra/issues/73#issuecomment-1250462398
https://github.com/apache/pulsar/pull/17709 patch on the main repo. We can double-check in the bot logic, but filtering out in the workflow can reduce one runner scheduled for the check inside the bot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] tisonkun commented on issue #73: [pulsarbot] Bot should not comment on closed/merged PRs
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #73:
URL: https://github.com/apache/pulsar-test-infra/issues/73#issuecomment-1250326032
> I have an idea, if the PR description is incorrect and the state is merged or closed, we will no longer add a comment.
Yes. Check the PR state in the bot or filter out in the workflow is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] merlimat closed issue #73: [pulsarbot] Bot should not comment on closed/merged PRs
Posted by GitBox <gi...@apache.org>.
merlimat closed issue #73: [pulsarbot] Bot should not comment on closed/merged PRs
URL: https://github.com/apache/pulsar-test-infra/issues/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] nodece commented on issue #73: [pulsarbot] Bot should not comment on closed/merged PRs
Posted by GitBox <gi...@apache.org>.
nodece commented on issue #73:
URL: https://github.com/apache/pulsar-test-infra/issues/73#issuecomment-1250325474
This is a good catch! Currently, the `docbot` adds a doc label based on the PR description, when the PR description is incorrect, we still add a comment.
**Note:** For the doc label, we can only change the PR description, and then the `docbot` will check this and do the labeling.
I have an idea, if the PR description is incorrect and the state is merged or closed, we will no longer add a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org