You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/15 02:33:25 UTC
[GitHub] [camel-quarkus] djencks opened a new pull request #3385: POC/WIP local build setup
djencks opened a new pull request #3385:
URL: https://github.com/apache/camel-quarkus/pull/3385
See https://github.com/apache/camel-website/issues/720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3385: POC/WIP local build setup
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3385:
URL: https://github.com/apache/camel-quarkus/pull/3385#issuecomment-995058457
@djencks the setup issue on my machine has no link with this specific PR. It's just I can't generate the doc locally independent from this PR.
I was asking a bout a simple way to check the PR. And it looks there is not. So I guess it's ok to merge and see how it's going :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3385: POC/WIP local build setup
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3385:
URL: https://github.com/apache/camel-quarkus/pull/3385#discussion_r769740585
##########
File path: docs/pom.xml
##########
@@ -85,45 +85,45 @@
</activation>
<build>
<plugins>
- <plugin>
- <groupId>com.github.eirslett</groupId>
- <artifactId>frontend-maven-plugin</artifactId>
- <version>${frontend-maven-plugin.version}</version>
- <executions>
- <execution>
- <id>install node and yarn</id>
- <goals>
- <goal>install-node-and-yarn</goal>
- </goals>
- <configuration>
- <nodeVersion>v14.16.0</nodeVersion>
- <yarnVersion>v1.22.5</yarnVersion>
- </configuration>
- </execution>
- <execution>
- <id>yarn install</id>
- <goals>
- <goal>yarn</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>install --immutable</arguments>
- </configuration>
- </execution>
- <!-- TODO: Enable checks once docs issues are fixed https://github.com/apache/camel-quarkus/issues/3307
- <execution>
- <id>antora-xref-check</id>
- <goals>
- <goal>yarn</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>run checks</arguments>
- </configuration>
- </execution>
- -->
- </executions>
- </plugin>
+<!-- <plugin>-->
Review comment:
This whole section is commented now. So, is it relevant to keep it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] djencks commented on pull request #3385: POC/WIP local build setup
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #3385:
URL: https://github.com/apache/camel-quarkus/pull/3385#issuecomment-995035663
> @djencks I don't know the doc part that much and can't run it locally because of setup issues. Yet, let me do my best to review.
Could you elaborate on the setup issues? The instructions are in my dev list post on local partial builds. If the instructions are unclear or don't work I'd like to know :-)
> One question thought, is there a simple way to double check that this PR does not break the doc ?
I'm not quite sure what you are asking. The only sure way to check is to do a website PR build as described here: https://camel.apache.org/manual/improving-the-documentation.html#_creating_a_documentation_pull_request. Unfortunately this is not simple :-) Doing a "full local build" as described in the dev list post is almost as good and much simpler. However, since the changes here don't change anything about the stuff used in the actual website build, they are unlikely to break it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #3385: POC/WIP local build setup
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #3385:
URL: https://github.com/apache/camel-quarkus/pull/3385#issuecomment-994906086
@djencks I don't know the doc part that much and can't run it locally because of setup issues. Yet, let me do my best to review.
One question thought, is there a simple way to double check that this PR does not break the doc ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] djencks merged pull request #3385: POC/WIP local build setup
Posted by GitBox <gi...@apache.org>.
djencks merged pull request #3385:
URL: https://github.com/apache/camel-quarkus/pull/3385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] djencks commented on a change in pull request #3385: POC/WIP local build setup
Posted by GitBox <gi...@apache.org>.
djencks commented on a change in pull request #3385:
URL: https://github.com/apache/camel-quarkus/pull/3385#discussion_r769862992
##########
File path: docs/pom.xml
##########
@@ -85,45 +85,45 @@
</activation>
<build>
<plugins>
- <plugin>
- <groupId>com.github.eirslett</groupId>
- <artifactId>frontend-maven-plugin</artifactId>
- <version>${frontend-maven-plugin.version}</version>
- <executions>
- <execution>
- <id>install node and yarn</id>
- <goals>
- <goal>install-node-and-yarn</goal>
- </goals>
- <configuration>
- <nodeVersion>v14.16.0</nodeVersion>
- <yarnVersion>v1.22.5</yarnVersion>
- </configuration>
- </execution>
- <execution>
- <id>yarn install</id>
- <goals>
- <goal>yarn</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>install --immutable</arguments>
- </configuration>
- </execution>
- <!-- TODO: Enable checks once docs issues are fixed https://github.com/apache/camel-quarkus/issues/3307
- <execution>
- <id>antora-xref-check</id>
- <goals>
- <goal>yarn</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>run checks</arguments>
- </configuration>
- </execution>
- -->
- </executions>
- </plugin>
+<!-- <plugin>-->
Review comment:
There's no point in keeping it's current state, but I left it there to help me think about whether there's a plausible way to do a partial docs build as part of the maven build... so far I don't see a good way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3385: POC/WIP local build setup
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #3385:
URL: https://github.com/apache/camel-quarkus/pull/3385#discussion_r769882211
##########
File path: docs/pom.xml
##########
@@ -85,45 +85,45 @@
</activation>
<build>
<plugins>
- <plugin>
- <groupId>com.github.eirslett</groupId>
- <artifactId>frontend-maven-plugin</artifactId>
- <version>${frontend-maven-plugin.version}</version>
- <executions>
- <execution>
- <id>install node and yarn</id>
- <goals>
- <goal>install-node-and-yarn</goal>
- </goals>
- <configuration>
- <nodeVersion>v14.16.0</nodeVersion>
- <yarnVersion>v1.22.5</yarnVersion>
- </configuration>
- </execution>
- <execution>
- <id>yarn install</id>
- <goals>
- <goal>yarn</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>install --immutable</arguments>
- </configuration>
- </execution>
- <!-- TODO: Enable checks once docs issues are fixed https://github.com/apache/camel-quarkus/issues/3307
- <execution>
- <id>antora-xref-check</id>
- <goals>
- <goal>yarn</goal>
- </goals>
- <phase>verify</phase>
- <configuration>
- <arguments>run checks</arguments>
- </configuration>
- </execution>
- -->
- </executions>
- </plugin>
+<!-- <plugin>-->
Review comment:
ok I see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org