You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/01 13:44:20 UTC
[GitHub] [hive] wangyum opened a new pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
wangyum opened a new pull request #1723:
URL: https://github.com/apache/hive/pull/1723
### What changes were proposed in this pull request?
HIVE-17234 has removed HBase metastore from master. But maven dependency have not been removed. We should remove it.
### Why are the changes needed?
Reduce dependency.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wangyum commented on pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #1723:
URL: https://github.com/apache/hive/pull/1723#issuecomment-736900774
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1723:
URL: https://github.com/apache/hive/pull/1723#issuecomment-738461352
Merged. Thanks @wangyum !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on a change in pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #1723:
URL: https://github.com/apache/hive/pull/1723#discussion_r535502356
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestWorker.java
##########
@@ -17,7 +17,6 @@
*/
package org.apache.hadoop.hive.ql.txn.compactor;
-import it.unimi.dsi.fastutil.booleans.AbstractBooleanBidirectionalIterator;
Review comment:
is this related?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wangyum commented on pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #1723:
URL: https://github.com/apache/hive/pull/1723#issuecomment-737005813
cc @alanfgates @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
Posted by GitBox <gi...@apache.org>.
sunchao merged pull request #1723:
URL: https://github.com/apache/hive/pull/1723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wangyum removed a comment on pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
Posted by GitBox <gi...@apache.org>.
wangyum removed a comment on pull request #1723:
URL: https://github.com/apache/hive/pull/1723#issuecomment-736900774
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wangyum commented on a change in pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #1723:
URL: https://github.com/apache/hive/pull/1723#discussion_r533473733
##########
File path: ql/pom.xml
##########
@@ -820,6 +820,12 @@
<version>${guava.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>it.unimi.dsi</groupId>
+ <artifactId>fastutil</artifactId>
+ <version>6.5.6</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
https://github.com/apache/hive/blob/4b670877c280b37c5776046f66d766079489b2a8/ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestWorker.java#L20 need this dependency:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on a change in pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #1723:
URL: https://github.com/apache/hive/pull/1723#discussion_r535735693
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestWorker.java
##########
@@ -17,7 +17,6 @@
*/
package org.apache.hadoop.hive.ql.txn.compactor;
-import it.unimi.dsi.fastutil.booleans.AbstractBooleanBidirectionalIterator;
Review comment:
Gotcha, cool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] wangyum commented on a change in pull request #1723: HIVE-21588: Remove HBase dependency from hive-metastore
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #1723:
URL: https://github.com/apache/hive/pull/1723#discussion_r535725208
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestWorker.java
##########
@@ -17,7 +17,6 @@
*/
package org.apache.hadoop.hive.ql.txn.compactor;
-import it.unimi.dsi.fastutil.booleans.AbstractBooleanBidirectionalIterator;
Review comment:
Yes, this need `it.unimi.dsi:fastutil`, we have removed this dependency:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org