You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/05 10:52:25 UTC

[GitHub] flink pull request #3831: [FLINK-5978][FLINK-6459][FLINK-6461] Move web-rela...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3831

    [FLINK-5978][FLINK-6459][FLINK-6461] Move web-related config parameters to JMOptions

    This PR contains the remaining steps to moving all web-related configuration parameters to the `JobManagerOptions` class.
    
    * contains a rebased and cleaned up version of #3552 
    * moves the `ACCESS_CONTROL_ORIGIN` ConfigOption
    * deprecates the remaining web-related default values in ConfigConstants, and replaces all usages of them

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink web_config_stuff

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3831
    
----
commit a353214a2b770262e8ac2537fd7b23a81f0a5aca
Author: mengji.fy <me...@taobao.com>
Date:   2017-05-05T10:11:20Z

    [FLINK-5978] Move JM WebFrontend address ConfigOption to JMOptions
    
    This closes #3552.

commit 34598d58185e6bfeb33709e890511226c10f2fa5
Author: zentol <ch...@apache.org>
Date:   2017-05-05T10:13:10Z

    [FLINK-6459] Move origin header ConfigOption to JMOptions

commit d674fa7ce4007adbe36760c4cc175949efa145eb
Author: zentol <ch...@apache.org>
Date:   2017-05-05T10:39:55Z

    [FLINK-6461] Deprecate web config defaults in ConfigConstants

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3831: [FLINK-5978][FLINK-6459][FLINK-6461] Move web-related con...

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3831
  
    Will this also be merged to 1.3.0? If not, 1.4 will need to replace and deprecate `JOB_MANAGER_WEB_ACCESS_CONTROL_ALLOW_ORIGIN`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3831: [FLINK-5978][FLINK-6459][FLINK-6461] Move web-related con...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3831
  
    merging to 1.4.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3831: [FLINK-5978][FLINK-6459][FLINK-6461] Move web-related con...

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3831
  
    Are we also deprecating use of the default values in `ConfigConstants`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3831: [FLINK-5978][FLINK-6459][FLINK-6461] Move web-related con...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3831
  
    I guess this also means i now have to worry about hte order in which i merge things to the branches, urgh.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3831: [FLINK-5978][FLINK-6459][FLINK-6461] Move web-related con...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3831
  
    Good point, Ill merge the access-control-origin commit to 1.3 as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3831: [FLINK-5978][FLINK-6459][FLINK-6461] Move web-related con...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3831
  
    I would think that default values in `ConfigConstants` should be deprecated as well, as they are generally subsumed by the corresponding `ConfigOption`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3831: [FLINK-5978][FLINK-6459][FLINK-6461] Move web-rela...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3831


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3831: [FLINK-5978][FLINK-6459][FLINK-6461] Move web-related con...

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3831
  
    +1 to merge for 1.3.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---