You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/02/06 10:19:05 UTC

[GitHub] [druid] maytasm commented on a change in pull request #12228: Add a flag to allow auto compaction task slot ratio to consider auto scaler slots

maytasm commented on a change in pull request #12228:
URL: https://github.com/apache/druid/pull/12228#discussion_r800157808



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/autoscaling/PendingTaskBasedWorkerProvisioningStrategy.java
##########
@@ -138,6 +138,11 @@ public PendingTaskBasedWorkerProvisioningStrategy(
     this.workerConfigRef = workerConfigRef;
   }
 
+  public PendingTaskBasedWorkerProvisioningConfig getConfig()

Review comment:
       Neither the `config` nor the `workerCapacityHint` is needed outside of the `ProvisioningStrategy` class now. However, using this idea, I added a new method, `getExpectedWorkerCapacity` to the `ProvisioningStrategy` interface. This method internally call and reuses the method to calculate per worker expected capacity that already existed in the `ProvisioningStrategy` class. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org