[jira] [Commented] (IMPALA-13252) Filter update log message prints TUniqueId in non-standard format

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869283#comment-17869283 ] 

ASF subversion and git services commented on IMPALA-13252:
----------------------------------------------------------

Commit 8d4497be0947e7552e0e9e2c15b9b08566aad148 in impala's branch refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8d4497be0 ]

IMPALA-13252: Consistently use PrintId to print TUniqueId

Some logging formats TUniqueId inconsistently by relying on the Thrift
to_string/toString generated printers. This makes it difficult to track
a specific query through logs.

Adds operator<<(ostream, TUniqueId) to simplify logging TUniqueId
correctly, uses PrintId instead of toString in Java, and adds a verifier
to test_banned_log_messages to ensure TUniqueId is not printed in logs.

Change-Id: If01bf20a240debbbd4c0a22798045ea03f17b28e
Reviewed-on: http://gerrit.cloudera.org:8080/21606
Reviewed-by: Yida Wu <wy...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Filter update log message prints TUniqueId in non-standard format
> -----------------------------------------------------------------
>
>                 Key: IMPALA-13252
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13252
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.4.0
>            Reporter: Michael Smith
>            Assignee: Michael Smith
>            Priority: Major
>
> Some error messages, such as
> {code}
> Filter update received for non-executing query with id: TUniqueId(hi=-8482965541048796556, lo=3501357296473079808)
> {code}
> print query id as the raw Thrift type rather than our colon-delimited format, e.g. "8a4673c8fbe83a74:309751e900000000". This makes it difficult to trace queries through logs.
> Normalize on the colon-delimited format.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org