[GitHub] [tvm] guberti commented on a diff in pull request #12671: [microTVM] Allow int8 operations for Cortex-M cores

[GitBox <gi...@apache.org>]

guberti commented on code in PR #12671:
URL: https://github.com/apache/tvm/pull/12671#discussion_r961315831


##########
python/tvm/relay/qnn/op/legalizations.py:
##########
@@ -433,15 +439,15 @@ def _qnn_conv2d_legalize_arm_cpu(attrs, inputs, types):
         attrs["groups"],
     )
     use_int8_on_arm = (not is_depthwise) and is_aarch64_arm() and attrs["data_layout"] == "NHWC"
-    if use_int8_on_arm or is_fast_int8_on_arm():
+    if use_int8_on_arm or is_fast_int8_on_arm() or is_cortexm_arm():

Review Comment:
   I put some additional justification in the `is_cortexm_arm` docstring - let me know if you still have questions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org