You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/12/16 00:51:34 UTC
Review Request 54800: Implemented `os::user' on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54800/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, John Kordich, and Joseph Wu.
Bugs: MESOS-6761
https://issues.apache.org/jira/browse/MESOS-6761
Repository: mesos
Description
-------
Implemented `os::user' on Windows.
Diffs
-----
3rdparty/stout/cmake/StoutConfigure.cmake 7e483aa9c433ac40d108971d012bc76fa61ba860
3rdparty/stout/include/stout/os/windows/su.hpp 1bb70964adbb80aa6502fbfe69de2c34dc74e655
3rdparty/stout/tests/os_tests.cpp bed1449ef8855932a1fefd3aeb3386ab9abd0307
Diff: https://reviews.apache.org/r/54800/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 54800: Implemented `os::user' on Windows.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54800/#review159395
-----------------------------------------------------------
Ship it!
I can fix these before committing.
3rdparty/stout/include/stout/os/windows/su.hpp (line 43)
<https://reviews.apache.org/r/54800/#comment230398>
Nit: `// SECURITY_WIN32 || SECURITY_KERNEL`
3rdparty/stout/include/stout/os/windows/su.hpp (lines 77 - 78)
<https://reviews.apache.org/r/54800/#comment230399>
Hum, I think this error reads more clearly:
```
os::user: Retrieving user information via uid is not supported on Windows
```
- Joseph Wu
On Dec. 15, 2016, 4:53 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54800/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 4:53 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, and Joseph Wu.
>
>
> Bugs: MESOS-6761
> https://issues.apache.org/jira/browse/MESOS-6761
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented `os::user' on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/stout/cmake/StoutConfigure.cmake 7e483aa9c433ac40d108971d012bc76fa61ba860
> 3rdparty/stout/include/stout/os/windows/su.hpp 1bb70964adbb80aa6502fbfe69de2c34dc74e655
> 3rdparty/stout/tests/os_tests.cpp bed1449ef8855932a1fefd3aeb3386ab9abd0307
>
> Diff: https://reviews.apache.org/r/54800/diff/
>
>
> Testing
> -------
>
> This is a slight revamp of dpravat's https://reviews.apache.org/r/53706/. Agreement is, Joseph will check this in under Daniel's name so he retains credit.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 54800: Implemented `os::user' on Windows.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54800/
-----------------------------------------------------------
(Updated Dec. 16, 2016, 12:53 a.m.)
Review request for mesos, Andrew Schwartzmeyer, John Kordich, and Joseph Wu.
Bugs: MESOS-6761
https://issues.apache.org/jira/browse/MESOS-6761
Repository: mesos
Description
-------
Implemented `os::user' on Windows.
Diffs
-----
3rdparty/stout/cmake/StoutConfigure.cmake 7e483aa9c433ac40d108971d012bc76fa61ba860
3rdparty/stout/include/stout/os/windows/su.hpp 1bb70964adbb80aa6502fbfe69de2c34dc74e655
3rdparty/stout/tests/os_tests.cpp bed1449ef8855932a1fefd3aeb3386ab9abd0307
Diff: https://reviews.apache.org/r/54800/diff/
Testing (updated)
-------
This is a slight revamp of dpravat's https://reviews.apache.org/r/53706/. Agreement is, Joseph will check this in under Daniel's name so he retains credit.
Thanks,
Alex Clemmer