Re: [PR] Add flag to allow diabling creation of catalog tables [iceberg-python]

["isc-patrick (via GitHub)" <gi...@apache.org>]

isc-patrick commented on code in PR #1155:
URL: https://github.com/apache/iceberg-python/pull/1155#discussion_r1763399699


##########
tests/catalog/test_sql.py:
##########
@@ -225,6 +237,93 @@ def test_creation_from_impl(catalog_name: str, warehouse: Path) -> None:
     )
 
 
+def confirm_no_tables_exist(alchemy_engine: Engine) -> list[str]:

Review Comment:
   Not returning this anymore, so removed, CATALOG_TABLES is no a constant. PR title updated and flag added to docs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org