You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/05 16:56:17 UTC
[GitHub] [pulsar] merlimat commented on a change in pull request #10130: Reduce redundant logs on Producer/Consumer create/close operations
merlimat commented on a change in pull request #10130:
URL: https://github.com/apache/pulsar/pull/10130#discussion_r607199621
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1193,7 +1193,7 @@ protected void handleProducer(final CommandProducer cmdProducer) {
topic.addProducer(producer, producerQueuedFuture).thenAccept(newTopicEpoch -> {
if (isActive()) {
if (producerFuture.complete(producer)) {
- log.info("[{}] Created new producer: {}", remoteAddress, producer);
+ log.debug("[{}] Created new producer: {}", remoteAddress, producer);
Review comment:
I don't think these are redundant as in they're logging when a producer is effectively active.
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1208,11 +1208,11 @@ protected void handleProducer(final CommandProducer cmdProducer) {
}
} else {
producer.closeNow(true);
- log.info("[{}] Cleared producer created after connection was closed: {}",
- remoteAddress, producer);
- producerFuture.completeExceptionally(
- new IllegalStateException(
- "Producer created after connection was closed"));
+ log.info("[{}] Cleared producer created after connection was closed: {}",
Review comment:
Same here, when a connection is closed, we log all the producer that were cleared
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1923,7 +1923,7 @@ protected void handleEndTxnOnSubscription(CommandEndTxnOnSubscription command) {
return topic.addSchema(schema);
} else {
return topic.hasSchema().thenCompose((hasSchema) -> {
- log.info("[{}] {} configured with schema {}",
+ log.debug("[{}] {} configured with schema {}",
Review comment:
This one is good to reduce the level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org