You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2018/03/07 13:56:04 UTC
Review Request 65949: ATLAS-2485 : UI ,
Unable to add tag to entity from Tags Search Page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65949/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-2485
https://issues.apache.org/jira/browse/ATLAS-2485
Repository: atlas
Description
-------
Tag Association window doesn't open when tag is attempted to be added by clicking the + Button shown corresponding to the entities shown in the Tags Search Page.
On clicking the + Button , following stack trace is seen in Console tab of browser.
TypeError: undefined is not an object (evaluating 'this.tagCollection.fullCollection')
tagsCollectionAddTagModalView.js:138
onRenderAddTagModalView.js:116
(anonymous function)backbone.marionette.min.js:1:7823
triggerMethodbackbone.marionette.min.js:1:20699
renderbackbone.marionette.min.js:1:28711
(anonymous function)
renderModal.js:35:97
openModal.js:43
initializeAddTagModalView.js:54
Viewbackbone-min.js:1:13838
constructorbackbone.marionette.min.js:1:17255
constructorbackbone.marionette.min.js:1:22359
constructorbackbone.marionette.min.js:1:27981
(anonymous function)backbone-min.js:1:21782
(anonymous function)SearchResultLayoutView.js:506
execCbrequire.js:1:12902
checkrequire.js:1:6639
(anonymous function)require.js:1:9059
(anonymous function)require.js:1:819
(anonymous function)require.js:1:9516
eachrequire.js:1:290
emitrequire.js:1:9487
checkrequire.js:1:7196
(anonymous function)require.js:1:9059
(anonymous function)require.js:1:819
(anonymous function)require.js:1:9516
eachrequire.js:1:290
emitrequire.js:1:9487
checkrequire.js:1:7196
(anonymous function)require.js:1:9059
(anonymous function)require.js:1:819
(anonymous function)require.js:1:9516
eachrequire.js:1:290
emitrequire.js:1:9487
checkrequire.js:1:7196
enablerequire.js:1:9386
initrequire.js:1:5744
(anonymous function)require.js:1:8052
(anonymous function)require.js:1:819
execCbrequire.js:1:12902
checkrequire.js:1:6639
enablerequire.js:1:9386
initrequire.js:1:5744
(anonymous function)require.js:1:11266
CC : Kamlesh Bhatt [~ppandey]
Diffs
-----
dashboardv2/public/js/views/tag/TagDetailLayoutView.js 27f76bc
Diff: https://reviews.apache.org/r/65949/diff/1/
Testing
-------
Done one round of sanity testing.
Thanks,
pratik pandey
Re: Review Request 65949: ATLAS-2485 : UI ,
Unable to add tag to entity from Tags Search Page
Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65949/#review198875
-----------------------------------------------------------
Ship it!
Ship It!
- keval bhatt
On March 7, 2018, 1:56 p.m., pratik pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65949/
> -----------------------------------------------------------
>
> (Updated March 7, 2018, 1:56 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2485
> https://issues.apache.org/jira/browse/ATLAS-2485
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Tag Association window doesn't open when tag is attempted to be added by clicking the + Button shown corresponding to the entities shown in the Tags Search Page.
>
> On clicking the + Button , following stack trace is seen in Console tab of browser.
>
> TypeError: undefined is not an object (evaluating 'this.tagCollection.fullCollection')
> tagsCollectionAddTagModalView.js:138
> onRenderAddTagModalView.js:116
> (anonymous function)backbone.marionette.min.js:1:7823
> triggerMethodbackbone.marionette.min.js:1:20699
> renderbackbone.marionette.min.js:1:28711
> (anonymous function)
> renderModal.js:35:97
> openModal.js:43
> initializeAddTagModalView.js:54
> Viewbackbone-min.js:1:13838
> constructorbackbone.marionette.min.js:1:17255
> constructorbackbone.marionette.min.js:1:22359
> constructorbackbone.marionette.min.js:1:27981
> (anonymous function)backbone-min.js:1:21782
> (anonymous function)SearchResultLayoutView.js:506
> execCbrequire.js:1:12902
> checkrequire.js:1:6639
> (anonymous function)require.js:1:9059
> (anonymous function)require.js:1:819
> (anonymous function)require.js:1:9516
> eachrequire.js:1:290
> emitrequire.js:1:9487
> checkrequire.js:1:7196
> (anonymous function)require.js:1:9059
> (anonymous function)require.js:1:819
> (anonymous function)require.js:1:9516
> eachrequire.js:1:290
> emitrequire.js:1:9487
> checkrequire.js:1:7196
> (anonymous function)require.js:1:9059
> (anonymous function)require.js:1:819
> (anonymous function)require.js:1:9516
> eachrequire.js:1:290
> emitrequire.js:1:9487
> checkrequire.js:1:7196
> enablerequire.js:1:9386
> initrequire.js:1:5744
> (anonymous function)require.js:1:8052
> (anonymous function)require.js:1:819
> execCbrequire.js:1:12902
> checkrequire.js:1:6639
> enablerequire.js:1:9386
> initrequire.js:1:5744
> (anonymous function)require.js:1:11266
> CC : Kamlesh Bhatt [~ppandey]
>
>
> Diffs
> -----
>
> dashboardv2/public/js/views/tag/TagDetailLayoutView.js 27f76bc
>
>
> Diff: https://reviews.apache.org/r/65949/diff/1/
>
>
> Testing
> -------
>
> Done one round of sanity testing.
>
>
> Thanks,
>
> pratik pandey
>
>